* [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only
@ 2017-02-01 23:07 cornelius.weig
2017-02-01 23:07 ` [PATCH 2/2] completion: add completion for --recurse-submodules=only cornelius.weig
2017-02-01 23:16 ` [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only Junio C Hamano
0 siblings, 2 replies; 6+ messages in thread
From: cornelius.weig @ 2017-02-01 23:07 UTC (permalink / raw)
To: git; +Cc: bmwill, sbeller, Cornelius Weig
From: Cornelius Weig <cornelius.weig@tngtech.com>
Add documentation for the `--recurse-submodules=only` option of
git-push. The feature was added in commit 225e8bf (add option to
push only submodules).
Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
---
Notes:
This feature is already in 'next' but was undocumented. Unless somebody reads
the release notes, there is no way of knowing about it.
Documentation/git-push.txt | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index 8eefabd..1624a35 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt
@@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the
standard error stream is not directed to a terminal.
--no-recurse-submodules::
---recurse-submodules=check|on-demand|no::
+--recurse-submodules=check|on-demand|only|no::
May be used to make sure all submodule commits used by the
revisions to be pushed are available on a remote-tracking branch.
If 'check' is used Git will verify that all submodule commits that
@@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the
remote of the submodule. If any commits are missing the push will
be aborted and exit with non-zero status. If 'on-demand' is used
all submodules that changed in the revisions to be pushed will be
- pushed. If on-demand was not able to push all necessary revisions
- it will also be aborted and exit with non-zero status. A value of
- 'no' or using `--no-recurse-submodules` can be used to override the
- push.recurseSubmodules configuration variable when no submodule
- recursion is required.
+ pushed. If on-demand was not able to push all necessary revisions it will
+ also be aborted and exit with non-zero status. If 'only' is used all
+ submodules will be recursively pushed while the superproject is left
+ unpushed. A value of 'no' or using `--no-recurse-submodules` can be used
+ to override the push.recurseSubmodules configuration variable when no
+ submodule recursion is required.
--[no-]verify::
Toggle the pre-push hook (see linkgit:githooks[5]). The
--
2.10.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] completion: add completion for --recurse-submodules=only
2017-02-01 23:07 [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only cornelius.weig
@ 2017-02-01 23:07 ` cornelius.weig
2017-02-02 9:30 ` Stefan Beller
2017-02-01 23:16 ` [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only Junio C Hamano
1 sibling, 1 reply; 6+ messages in thread
From: cornelius.weig @ 2017-02-01 23:07 UTC (permalink / raw)
To: git; +Cc: bmwill, sbeller, Cornelius Weig
From: Cornelius Weig <cornelius.weig@tngtech.com>
Command completion for 'git-push --recurse-submodules' already knows to
complete some modes. However, the recently added mode 'only' is missing.
Adding 'only' to the recognized modes completes the list of non-trivial
modes.
Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index ff7072a..fe3b0f8 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1675,7 +1675,7 @@ _git_pull ()
__git_complete_remote_or_refspec
}
-__git_push_recurse_submodules="check on-demand"
+__git_push_recurse_submodules="check on-demand only"
__git_complete_force_with_lease ()
{
--
2.10.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] completion: add completion for --recurse-submodules=only
2017-02-01 23:07 ` [PATCH 2/2] completion: add completion for --recurse-submodules=only cornelius.weig
@ 2017-02-02 9:30 ` Stefan Beller
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Beller @ 2017-02-02 9:30 UTC (permalink / raw)
To: Cornelius Weig; +Cc: git@vger.kernel.org, Brandon Williams
On Wed, Feb 1, 2017 at 3:07 PM, <cornelius.weig@tngtech.com> wrote:
> From: Cornelius Weig <cornelius.weig@tngtech.com>
>
> Command completion for 'git-push --recurse-submodules' already knows to
> complete some modes. However, the recently added mode 'only' is missing.
>
> Adding 'only' to the recognized modes completes the list of non-trivial
> modes.
>
> Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
> ---
Looks good,
Thanks,
Stefan
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index ff7072a..fe3b0f8 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1675,7 +1675,7 @@ _git_pull ()
> __git_complete_remote_or_refspec
> }
>
> -__git_push_recurse_submodules="check on-demand"
> +__git_push_recurse_submodules="check on-demand only"
>
> __git_complete_force_with_lease ()
> {
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only
2017-02-01 23:07 [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only cornelius.weig
2017-02-01 23:07 ` [PATCH 2/2] completion: add completion for --recurse-submodules=only cornelius.weig
@ 2017-02-01 23:16 ` Junio C Hamano
[not found] ` <CAKoko1q=6agpGsABxy8rmm6sGFWx9gE_c1j44h4M=yJ3r4JJBQ@mail.gmail.com>
2017-02-04 12:05 ` Cornelius Weig
1 sibling, 2 replies; 6+ messages in thread
From: Junio C Hamano @ 2017-02-01 23:16 UTC (permalink / raw)
To: cornelius.weig; +Cc: git, bmwill, sbeller
cornelius.weig@tngtech.com writes:
> From: Cornelius Weig <cornelius.weig@tngtech.com>
>
> Add documentation for the `--recurse-submodules=only` option of
> git-push. The feature was added in commit 225e8bf (add option to
> push only submodules).
>
> Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
> ---
>
> Notes:
> This feature is already in 'next' but was undocumented. Unless somebody reads
> the release notes, there is no way of knowing about it.
Good eyes; the topic bw/push-submodule-only is already in 'master'.
Looks good to me; Brandon?
>
> Documentation/git-push.txt | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index 8eefabd..1624a35 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the
> standard error stream is not directed to a terminal.
>
> --no-recurse-submodules::
> ---recurse-submodules=check|on-demand|no::
> +--recurse-submodules=check|on-demand|only|no::
> May be used to make sure all submodule commits used by the
> revisions to be pushed are available on a remote-tracking branch.
> If 'check' is used Git will verify that all submodule commits that
> @@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the
> remote of the submodule. If any commits are missing the push will
> be aborted and exit with non-zero status. If 'on-demand' is used
> all submodules that changed in the revisions to be pushed will be
> - pushed. If on-demand was not able to push all necessary revisions
> - it will also be aborted and exit with non-zero status. A value of
> - 'no' or using `--no-recurse-submodules` can be used to override the
> - push.recurseSubmodules configuration variable when no submodule
> - recursion is required.
> + pushed. If on-demand was not able to push all necessary revisions it will
> + also be aborted and exit with non-zero status. If 'only' is used all
> + submodules will be recursively pushed while the superproject is left
> + unpushed. A value of 'no' or using `--no-recurse-submodules` can be used
> + to override the push.recurseSubmodules configuration variable when no
> + submodule recursion is required.
>
> --[no-]verify::
> Toggle the pre-push hook (see linkgit:githooks[5]). The
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <CAKoko1q=6agpGsABxy8rmm6sGFWx9gE_c1j44h4M=yJ3r4JJBQ@mail.gmail.com>]
* Fwd: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only
[not found] ` <CAKoko1q=6agpGsABxy8rmm6sGFWx9gE_c1j44h4M=yJ3r4JJBQ@mail.gmail.com>
@ 2017-02-02 9:32 ` Brandon Williams
0 siblings, 0 replies; 6+ messages in thread
From: Brandon Williams @ 2017-02-02 9:32 UTC (permalink / raw)
To: Git Mailing List
Looks good to me! Thanks for writing the documentation. I really
need to be better about getting documentation done at the same time
I'm adding features :)
-Brandon
On Wed, Feb 1, 2017 at 3:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> cornelius.weig@tngtech.com writes:
>
> > From: Cornelius Weig <cornelius.weig@tngtech.com>
> >
> > Add documentation for the `--recurse-submodules=only` option of
> > git-push. The feature was added in commit 225e8bf (add option to
> > push only submodules).
> >
> > Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
> > ---
> >
> > Notes:
> > This feature is already in 'next' but was undocumented. Unless somebody reads
> > the release notes, there is no way of knowing about it.
>
> Good eyes; the topic bw/push-submodule-only is already in 'master'.
>
> Looks good to me; Brandon?
>
> >
> > Documentation/git-push.txt | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> > index 8eefabd..1624a35 100644
> > --- a/Documentation/git-push.txt
> > +++ b/Documentation/git-push.txt
> > @@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the
> > standard error stream is not directed to a terminal.
> >
> > --no-recurse-submodules::
> > ---recurse-submodules=check|on-demand|no::
> > +--recurse-submodules=check|on-demand|only|no::
> > May be used to make sure all submodule commits used by the
> > revisions to be pushed are available on a remote-tracking branch.
> > If 'check' is used Git will verify that all submodule commits that
> > @@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the
> > remote of the submodule. If any commits are missing the push will
> > be aborted and exit with non-zero status. If 'on-demand' is used
> > all submodules that changed in the revisions to be pushed will be
> > - pushed. If on-demand was not able to push all necessary revisions
> > - it will also be aborted and exit with non-zero status. A value of
> > - 'no' or using `--no-recurse-submodules` can be used to override the
> > - push.recurseSubmodules configuration variable when no submodule
> > - recursion is required.
> > + pushed. If on-demand was not able to push all necessary revisions it will
> > + also be aborted and exit with non-zero status. If 'only' is used all
> > + submodules will be recursively pushed while the superproject is left
> > + unpushed. A value of 'no' or using `--no-recurse-submodules` can be used
> > + to override the push.recurseSubmodules configuration variable when no
> > + submodule recursion is required.
> >
> > --[no-]verify::
> > Toggle the pre-push hook (see linkgit:githooks[5]). The
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only
2017-02-01 23:16 ` [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only Junio C Hamano
[not found] ` <CAKoko1q=6agpGsABxy8rmm6sGFWx9gE_c1j44h4M=yJ3r4JJBQ@mail.gmail.com>
@ 2017-02-04 12:05 ` Cornelius Weig
1 sibling, 0 replies; 6+ messages in thread
From: Cornelius Weig @ 2017-02-04 12:05 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, bmwill, sbeller
Shouldn't this be part of v2.12-rc0? I just checked but it's not there.
Cheers,
Cornelius
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-04 12:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-01 23:07 [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only cornelius.weig
2017-02-01 23:07 ` [PATCH 2/2] completion: add completion for --recurse-submodules=only cornelius.weig
2017-02-02 9:30 ` Stefan Beller
2017-02-01 23:16 ` [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only Junio C Hamano
[not found] ` <CAKoko1q=6agpGsABxy8rmm6sGFWx9gE_c1j44h4M=yJ3r4JJBQ@mail.gmail.com>
2017-02-02 9:32 ` Fwd: " Brandon Williams
2017-02-04 12:05 ` Cornelius Weig
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).