From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pat Pannuto <pat.pannuto@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johannes Sixt <j6t@kdbg.org>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] Use 'env' to find perl instead of fixed path
Date: Fri, 13 Jan 2017 21:39:00 +0000 [thread overview]
Message-ID: <20170113213900.GA25890@starla> (raw)
In-Reply-To: <xmqq37gmhgpn.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Eric Wong <e@80x24.org> writes:
> > Junio C Hamano <gitster@pobox.com> wrote:
> >> Eric Wong <e@80x24.org> writes:
> >> > Pat Pannuto <pat.pannuto@gmail.com> wrote:
> >> >> You may still want the 1/2 patch in this series, just to make things
> >> >> internally consistent with "-w" vs "use warnings;" inside git's perl
> >> >> scripts.
> >> >
> >> > No, that is a step back. "-w" affects the entire process, so it
> >> > spots more potential problems. The "warnings" pragma is scoped
> >> > to the enclosing block, so it won't span across files.
> >>
> >> OK, so with "-w", we do not have to write "use warnings" in each of
> >> our files to get them checked. It is handy when we ship our own
> >> libs (e.g. Git.pm) that are used by our programs.
> >
> > Yes. "use warnings" should be in our own libs in case other
> > people run without "-w"
>
> Would it mean that we need both anyway? That is, add missing "use
> warnings" without removing "-w" from she-bang line?
Yes, we keep "use warnings" other people may use, at least.
No harm in keeping that in top-level scripts, I guess.
> Speaking of Perl, I recall that somebody complained that we ship
> with and do use a stale copy of Error.pm that has been deprecated.
> I am not asking you to do so, but we may want to see somebody look
> into it (i.e. assessing the current situation, and if it indeed is
> desirable for us to wean ourselves away from Error.pm, update our
> codepaths that use it).
Agreed, I'd definitely prefer to move towards the basic eval/die
construct without relying on a bundled 3rd-party mechanism.
But we might need a migration path for out-of-tree users of
Git.pm (if any)...
I'm sure I've agreed this was a path we should be taking in the
past, but did something about it myself. So yeah, maybe Pat or
somebody else interested can take care of this :)
Thanks.
next prev parent reply other threads:[~2017-01-13 21:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 5:51 [PATCH 0/2] Use env for all perl invocations Pat Pannuto
2017-01-12 5:51 ` [PATCH 1/2] Convert all 'perl -w' to 'perl' + 'use warnings;' Pat Pannuto
2017-01-12 5:51 ` [PATCH 2/2] Use 'env' to find perl instead of fixed path Pat Pannuto
2017-01-12 6:27 ` Johannes Sixt
2017-01-12 7:17 ` Pat Pannuto
2017-01-12 10:21 ` Johannes Schindelin
2017-01-12 20:40 ` Junio C Hamano
2017-01-12 21:01 ` Pat Pannuto
2017-01-12 21:49 ` Junio C Hamano
2017-01-13 2:48 ` Eric Wong
2017-01-13 15:27 ` Johannes Schindelin
2017-01-13 16:58 ` Eric Wong
2017-01-13 17:13 ` Johannes Schindelin
2017-01-13 18:27 ` Junio C Hamano
2017-01-13 18:52 ` Eric Wong
2017-01-13 20:01 ` Junio C Hamano
2017-01-13 21:39 ` Eric Wong [this message]
2017-01-14 7:54 ` Jeff King
2017-01-14 10:31 ` Eric Wong
2017-01-14 21:57 ` brian m. carlson
2017-01-13 15:21 ` Johannes Schindelin
2017-01-12 6:21 ` [PATCH 0/2] Use env for all perl invocations Junio C Hamano
2017-01-12 7:13 ` Pat Pannuto
2017-01-12 8:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113213900.GA25890@starla \
--to=e@80x24.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=pat.pannuto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).