From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pat Pannuto <pat.pannuto@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johannes Sixt <j6t@kdbg.org>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] Use 'env' to find perl instead of fixed path
Date: Fri, 13 Jan 2017 18:52:46 +0000 [thread overview]
Message-ID: <20170113185246.GA17441@starla> (raw)
In-Reply-To: <xmqq4m12izmd.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Eric Wong <e@80x24.org> writes:
> > Pat Pannuto <pat.pannuto@gmail.com> wrote:
> >> You may still want the 1/2 patch in this series, just to make things
> >> internally consistent with "-w" vs "use warnings;" inside git's perl
> >> scripts.
> >
> > No, that is a step back. "-w" affects the entire process, so it
> > spots more potential problems. The "warnings" pragma is scoped
> > to the enclosing block, so it won't span across files.
>
> OK, so with "-w", we do not have to write "use warnings" in each of
> our files to get them checked. It is handy when we ship our own
> libs (e.g. Git.pm) that are used by our programs.
Yes. "use warnings" should be in our own libs in case other
people run without "-w"
> If something we write outselves trigger a false-positive, we can
> work it around with "no warnings;" in the smallest block that
> encloses the offending code in the worst case, or just rephrase it
> in a way that won't trigger a false-positive.
Correct.
> If something we _use_ from a third-party is not warnings-clean,
> there is no easy way to squelch them if we use "-w", which is a
> potential downside, isn't it? I do not know how serious a problem
> it is in practice. I suspect that the core package we use from perl
> distribution are supposed to be warnings-clean, but we use a handful
> of things from outside the core and I do not know what state they
> are in.
Yes, "-w" will trigger warnings in third party packages.
Existing uses we have should be fine, and I think most Perl
modules we use or would use are vigilant about being
warnings-clean. If we have to leave off a "-w", there should
probably be a comment at the top stating the reason:
#!/usr/bin/perl
# Not using "perl -w" since Foo::Bar <= X.Y.Y is not warnings-clean
use strict;
use warnings;
use Foo::Bar;
...
next prev parent reply other threads:[~2017-01-13 18:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 5:51 [PATCH 0/2] Use env for all perl invocations Pat Pannuto
2017-01-12 5:51 ` [PATCH 1/2] Convert all 'perl -w' to 'perl' + 'use warnings;' Pat Pannuto
2017-01-12 5:51 ` [PATCH 2/2] Use 'env' to find perl instead of fixed path Pat Pannuto
2017-01-12 6:27 ` Johannes Sixt
2017-01-12 7:17 ` Pat Pannuto
2017-01-12 10:21 ` Johannes Schindelin
2017-01-12 20:40 ` Junio C Hamano
2017-01-12 21:01 ` Pat Pannuto
2017-01-12 21:49 ` Junio C Hamano
2017-01-13 2:48 ` Eric Wong
2017-01-13 15:27 ` Johannes Schindelin
2017-01-13 16:58 ` Eric Wong
2017-01-13 17:13 ` Johannes Schindelin
2017-01-13 18:27 ` Junio C Hamano
2017-01-13 18:52 ` Eric Wong [this message]
2017-01-13 20:01 ` Junio C Hamano
2017-01-13 21:39 ` Eric Wong
2017-01-14 7:54 ` Jeff King
2017-01-14 10:31 ` Eric Wong
2017-01-14 21:57 ` brian m. carlson
2017-01-13 15:21 ` Johannes Schindelin
2017-01-12 6:21 ` [PATCH 0/2] Use env for all perl invocations Junio C Hamano
2017-01-12 7:13 ` Pat Pannuto
2017-01-12 8:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113185246.GA17441@starla \
--to=e@80x24.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=pat.pannuto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).