From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()
Date: Mon, 19 Dec 2016 19:07:19 +0700 [thread overview]
Message-ID: <20161219120719.GF24125@ash> (raw)
In-Reply-To: <20161214151009.4wdzjb44f6aki5ug@sigill.intra.peff.net>
On Wed, Dec 14, 2016 at 10:10:10AM -0500, Jeff King wrote:
> diff --git a/parse-options.c b/parse-options.c
> index 312a85dbd..4fbe924a5 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -661,7 +661,7 @@ void NORETURN usage_msg_opt(const char *msg,
> const char * const *usagestr,
> const struct option *options)
> {
> - fprintf(stderr, "%s\n\n", msg);
> + fprintf(stderr, "fatal: %s\n\n", msg);
Your commit message does not make clear if you want this "fatal" to be
grep-able (by scripts) or not. If not, please _() the string. Maybe
this to reduce work for translators
/* TRANSLATORS: this is the prefix before usage error */
fprintf(stderr, "%s %s\n\n", _("fatal:"), msg);
> usage_with_options(usagestr, options);
> }
>
> --
> 2.11.0.341.g202cd3142
next prev parent reply other threads:[~2016-12-19 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 15:10 [PATCH] parse-options: print "fatal:" before usage_msg_opt() Jeff King
2016-12-14 17:57 ` Junio C Hamano
2016-12-19 12:07 ` Duy Nguyen [this message]
2016-12-19 13:41 ` Jeff King
2016-12-19 13:53 ` Duy Nguyen
2016-12-19 14:05 ` Jeff King
2016-12-19 14:30 ` Duy Nguyen
2016-12-19 14:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219120719.GF24125@ash \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).