From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] doc: fill in omitted word
Date: Thu, 10 Nov 2016 18:06:05 -0500 [thread overview]
Message-ID: <20161110230605.pwgzhai6xhud7pnu@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqd1i356ql.fsf@gitster.mtv.corp.google.com>
On Thu, Nov 10, 2016 at 02:07:30PM -0800, Junio C Hamano wrote:
> Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com> writes:
>
> > Signed-off-by: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>
> > ---
> > Documentation/gitcore-tutorial.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt
> > index 4546fa0..9860517 100644
> > --- a/Documentation/gitcore-tutorial.txt
> > +++ b/Documentation/gitcore-tutorial.txt
> > @@ -25,7 +25,7 @@ you want to understand Git's internals.
> > The core Git is often called "plumbing", with the prettier user
> > interfaces on top of it called "porcelain". You may not want to use the
> > plumbing directly very often, but it can be good to know what the
> > -plumbing does for when the porcelain isn't flushing.
> > +plumbing does for you when the porcelain isn't flushing.
>
> I need an English teacher here to help me out, but I think this
> changes the meaning of the sentence from what the original author
> intended..
It does. I'd take the original to mean "for the case when", which is
correct (though as you note, just dropping "for" says the same thing
more succinctly).
-Peff
next prev parent reply other threads:[~2016-11-10 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 21:43 [PATCH] doc: fill in omitted word Kristoffer Haugsbakk
2016-11-10 22:07 ` Junio C Hamano
2016-11-10 23:06 ` Jeff King [this message]
2016-12-09 12:31 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110230605.pwgzhai6xhud7pnu@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kristoffer.haugsbakk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).