From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Eric Wong" <e@80x24.org>, "Kyle J. McKay" <mackyle@gmail.com>,
git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH 1/1 v2] pager: move pager-specific setup into the build
Date: Mon, 1 Aug 2016 19:46:08 -0400 [thread overview]
Message-ID: <20160801234608.rsrrsnzywt5k7uzl@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq1t28gkhf.fsf@gitster.mtv.corp.google.com>
On Mon, Aug 01, 2016 at 04:03:40PM -0700, Junio C Hamano wrote:
> Eric Wong <e@80x24.org> writes:
>
> > From: Junio C Hamano <gitster@pobox.com>
> >
> > Allowing PAGER_ENV to be set at build-time allows us to move
> > pager-specific knowledge out of our build. Currently, this
> > allows us to set a better default for FreeBSD where more(1)
> > is the same binary as less(1).
>
> Thanks for resurrecting, but I am not sure what "a better default"
> is from the above description and with the patch. Even though a
> naive reading of the above (i.e. "less" and "more" are the same)
> makes me expect that the patch will give the same set of default
> environment settings to those on FreeBSD, you give LESS=FRX and
> MORE=-R, i.e. they are configured differently.
I wondered about this, too. They are the same binary, but calling less
as "more" (or setting LESS_IS_MORE) causes less to behave "like more".
Looking at the manpage, none the usual FRX options is affected. So in
theory we could just set MORE=FRX on FreeBSD.
That would be bad a idea in general, as other non-less implementations
of more might get confused. "more" is in POSIX, and so is $MORE (and it
does not understand any of our options).
You could also make the knob "MORE_IS_LESS" or something, and just
blindly copy $LESS to $MORE. That's a bad idea, though, if somebody does
stick one of the incompatible flags in the build options.
-Peff
next prev parent reply other threads:[~2016-08-01 23:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 1:05 [PATCH 0/2] add PAGER_ENV to build and core.pagerEnv to config Eric Wong
2016-08-01 1:05 ` [PATCH 1/2] pager: move pager-specific setup into the build Eric Wong
2016-08-01 1:43 ` brian m. carlson
2016-08-01 7:00 ` Eric Wong
2016-08-01 8:57 ` Jakub Narębski
2016-08-01 10:40 ` brian m. carlson
2016-08-01 17:24 ` Jeff King
2016-08-01 18:07 ` Junio C Hamano
2016-08-01 17:46 ` Duy Nguyen
2016-08-01 17:52 ` Jeff King
2016-08-01 18:01 ` Duy Nguyen
2016-08-01 18:07 ` Jeff King
2016-08-01 1:05 ` [PATCH 2/2] pager: implement core.pagerEnv in config Eric Wong
2016-08-01 17:28 ` Jeff King
2016-08-01 21:49 ` [PATCH 0/1 v2] add PAGER_ENV to build Eric Wong
2016-08-01 21:49 ` [PATCH 1/1 v2] pager: move pager-specific setup into the build Eric Wong
2016-08-01 23:03 ` Junio C Hamano
2016-08-01 23:46 ` Jeff King [this message]
2016-08-02 21:14 ` Junio C Hamano
2016-08-01 23:56 ` Eric Wong
2016-08-02 21:15 ` Junio C Hamano
2016-08-03 16:19 ` Jeff King
2016-08-03 20:57 ` Junio C Hamano
2016-08-03 21:08 ` Eric Wong
2016-08-03 21:15 ` Junio C Hamano
2016-08-04 3:43 ` [PATCH v3] " Eric Wong
2016-08-04 5:34 ` Jeff King
2016-08-04 11:34 ` Eric Wong
2016-08-04 17:53 ` Jeff King
2016-08-04 11:40 ` [PATCH v4] " Eric Wong
2016-08-03 21:09 ` [PATCH 1/1 v2] " Jeff King
2016-08-01 21:59 ` [PATCH 0/1 v2] add PAGER_ENV to build Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801234608.rsrrsnzywt5k7uzl@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=mackyle@gmail.com \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).