From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Shawn Pearce <spearce@spearce.org>,
Peter Foley <pefoley2@verizon.net>,
git@vger.kernel.org
Subject: Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory
Date: Mon, 20 Jun 2011 01:47:13 -0500 [thread overview]
Message-ID: <20110620064713.GA27992@elie> (raw)
In-Reply-To: <7vd3i9dow4.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Shawn Pearce <spearce@spearce.org> writes:
>> ... But why is this amount of churn necessary or being
>> recommended? What problem does this address? Is that worth the pain
>> this puts on every other in-flight change that is still being
>> developed, or is already in the review pipeline?
>
> No reason and not recommended; nothing; not worth.
>
> Especially during the pre-release freeze.
It's unlikely the patch would be cooked by the time there is a
release, or even in the moments of quiet after that. If this were a
patch intended for immediate inclusion, the timing would be
unfortunate, but for an RFC I wouldn't have expected the release
timing to be very relevant.
A better thought out version of this patch, meaning timed
appropriately and taking into account the comments that came up the
last times the subject was discussed, would imho be a good thing.
Part of thinking it through is to consider the effect on in-flight
patches and to consider whether it's possible to mitigate that.
In other words, I think Shawn's questions get right to the point.
I hope the above answers --- which do seem to correctly reflect the
state of things in absence of such thinking --- will not dissuade
someone from finding a good answer.
More prior discussion for the sort of masochistic person who wants to
work on it: [1]. I admit I can imagine easier tasks. :)
Just my two cents,
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/165748/focus=165801
next prev parent reply other threads:[~2011-06-20 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 0:50 [PATCH/RFC] Move contents of libgit.a to lib subdirectory Peter Foley
2011-06-20 1:06 ` Shawn Pearce
2011-06-20 1:21 ` Peter Foley
2011-06-20 5:59 ` Junio C Hamano
2011-06-20 6:47 ` Jonathan Nieder [this message]
2011-06-20 14:55 ` Thiago Farina
2011-06-20 1:12 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620064713.GA27992@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pefoley2@verizon.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).