From: Jonathan Nieder <jrnieder@gmail.com>
To: Peter Foley <pefoley2@verizon.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory
Date: Sun, 19 Jun 2011 20:12:45 -0500 [thread overview]
Message-ID: <20110620011245.GA25836@elie> (raw)
In-Reply-To: <alpine.LNX.2.00.1106192014410.41113@linux.foleyremote.com>
Hi,
Peter Foley wrote:
> This patch tries to organize the git source tree by moving the files which
> make up libgit.a to a lib subdirectory.
> Before this patch the toplevel source directory contained 285 files.
> After this patch the root directory will contain 167 files and
> the lib subdirectory will contain 119 files
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
> Makefile | 258 +++++++++++++-------------
> abspath.c => lib/abspath.c | 0
> advice.c => lib/advice.c | 0
[...]
> zlib.c => lib/zlib.c | 0
Thanks for a reminder. I had some vague hope that some "log --follow"
improvements[0] would arrive to make commands like "git log --follow
lib/branch.c" less painful, but that doesn't seem to be happening.
It's probably best not to wait forever.
As for the patch itself: my main thought is that I prefer to see
"branch.c" and "branch.h" in the same directory. Aside from that, I
like it. See [1] for some related discussion.
Regards,
Jonathan
[0] https://git.wiki.kernel.org/index.php/SoC2011Ideas#Better_git_log_--follow_support
[1] http://thread.gmane.org/gmane.comp.version-control.git/166424/focus=167154
prev parent reply other threads:[~2011-06-20 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 0:50 [PATCH/RFC] Move contents of libgit.a to lib subdirectory Peter Foley
2011-06-20 1:06 ` Shawn Pearce
2011-06-20 1:21 ` Peter Foley
2011-06-20 5:59 ` Junio C Hamano
2011-06-20 6:47 ` Jonathan Nieder
2011-06-20 14:55 ` Thiago Farina
2011-06-20 1:12 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620011245.GA25836@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pefoley2@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).