From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>, "SZEDER Gábor" <szeder@ira.uka.de>,
git@vger.kernel.org
Subject: Re: [BUG] 'add -u' doesn't work from untracked subdir
Date: Sat, 5 Sep 2009 10:46:41 +0200 [thread overview]
Message-ID: <20090905084641.GA24865@darc.dnsalias.org> (raw)
In-Reply-To: <7v8wgt98ms.fsf@alter.siamese.dyndns.org>
On Sat, Sep 05, 2009 at 12:02:35AM -0700, Junio C Hamano wrote:
> I personally find "add -u" that defaults to the current directory more
> natural than always going to the root; same preference for "grep".
> Besides, "add -u subdir" must add subdir relative to the cwd, without
> going to the root. Why should "add -u" sans argument behave drastically
> differently?
Sorry for stating the obvious here, but the following commands affect the
entire repository, even though they limit themselves to the current
directory, if passed a '.'.
git commit
git log
git diff
git checkout
git reset
Due to the frequent use of these commands, I believe many users (myself
included) expect "git add" and "git grep" to do the same. AFAICT the
following commands are the only non-plumbing ones that behave differently:
git add -u
git add -A
git grep
So I argue that _that_ is the real inconsistency.
> If "git add -u ../.." (I mean "the grand parent directory", not "an
> unnamed subdirectory") did not work, it would be unexcusable and we would
> want to devise an migration path, but otherwise I do not think it is such
> a big deal.
> I would say the commands that are used to incrementally build
> towards the next commit should be friendly to the practice of limiting the
> scope of the work by chdir.
"git add -u ." is friendly enough. Just like "git commit ." versus "git
commit -a", which is exactly the same concept and should therefore have the
same behavior.
You are assuming that people are in a subdirectory because they want to
limit the scope. But I am usually in a subdirectory for totally
versioning-unrelated reasons. Like running tests in git.git:t/ . I
mistakenly use "git add -u" in there all the time, because I think I don't
have to worry about which directory I'm in. Except in this instance I do.
In any case, I think it is better to have consistent behavior than to try
and read users' minds with defaults.
Clemens
next prev parent reply other threads:[~2009-09-05 8:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 8:03 [BUG] 'add -u' doesn't work from untracked subdir SZEDER Gábor
2009-09-02 8:19 ` Jeff King
2009-09-04 7:02 ` Clemens Buchacher
2009-09-05 6:18 ` Jeff King
2009-09-05 7:02 ` Junio C Hamano
2009-09-05 7:20 ` Jeff King
2009-09-05 7:58 ` Junio C Hamano
2009-09-05 8:02 ` Jeff King
2009-09-05 8:23 ` Junio C Hamano
2009-09-06 18:28 ` Clemens Buchacher
2009-09-09 23:46 ` Nanako Shiraishi
2009-09-10 19:53 ` Junio C Hamano
2009-09-10 20:32 ` Clemens Buchacher
2009-09-05 12:31 ` [PATCH 1/2] grep: accept relative paths outside current working directory Clemens Buchacher
2009-09-05 12:33 ` [PATCH 2/2] add 'scope' config option Clemens Buchacher
2009-09-05 13:10 ` [PATCH 2/2 v2] " Clemens Buchacher
2009-09-06 22:58 ` [PATCH 1/2] grep: accept relative paths outside current working directory Junio C Hamano
2009-09-07 8:48 ` [PATCH] grep: fix exit status if external_grep() returns error Clemens Buchacher
2009-09-07 18:13 ` Junio C Hamano
2009-09-05 8:19 ` [BUG] 'add -u' doesn't work from untracked subdir Jeff King
2009-09-05 7:25 ` Junio C Hamano
2009-09-05 8:46 ` Clemens Buchacher [this message]
2009-09-05 17:28 ` Junio C Hamano
2009-09-05 17:58 ` Jakub Narebski
2009-09-05 18:45 ` Clemens Buchacher
2009-09-05 21:46 ` 'add -u' without path is relative to cwd Junio C Hamano
2009-09-06 12:32 ` [BUG] 'add -u' doesn't work from untracked subdir Matthieu Moy
2009-09-06 18:16 ` Clemens Buchacher
2009-09-07 6:23 ` Matthieu Moy
2009-09-07 7:33 ` SZEDER Gábor
2009-09-07 8:06 ` Matthieu Moy
2009-09-07 0:07 ` Nanako Shiraishi
2009-09-07 5:07 ` Junio C Hamano
2009-09-07 7:50 ` Clemens Buchacher
2009-09-04 8:32 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090905084641.GA24865@darc.dnsalias.org \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).