From: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Petr Baudis <pasky@suse.cz>, Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: Libification project (SoC)
Date: Sat, 17 Mar 2007 19:58:32 +0000 [thread overview]
Message-ID: <20070317195832.2af87c06@home.brethil> (raw)
In-Reply-To: <20070316231646.GB4508@spearce.org>
On Fri, 16 Mar 2007 19:16:46 -0400
"Shawn O. Pearce" <spearce@spearce.org> wrote:
| "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br> wrote:
| > I think the right solution is to get rid of die() from functions that
| > are supposed to be an interface, set errno if needed and return -1
| > or NULL.
|
| And then make their callers (if they are above the public API layer)
| die instead. In some cases this might imply an undesirable change
| in the error message produced, as necessary details that are included
| today would be unavailable in the caller.
Exactly!
One simple example of an important error message that would be
lost can be found in read-cache.c:read_cache_from():
o index file smaller than expected
I've found a possible solution, though.
Take a look at Rusty's solution for the same problem in
module-init-tools:
"""
/* We use error numbers in a loose translation... */
static const char *insert_moderror(int err)
{
switch (err) {
case ENOEXEC:
return "Invalid module format";
case ENOENT:
return "Unknown symbol in module, or unknown parameter (see dmesg)";
case ENOSYS:
return "Kernel does not have module support";
default:
return strerror(err);
}
}
"""
Instead of calling strerror() directly for error generated
when inserting a module, the insmod() function calls insert_moderror()
which provides the desirable mapping.
I think we could have something like that for each git's
module, eg, git_cache_strerror(), git_commit_strerror() and so on.
Does this look reasonable?
--
Luiz Fernando N. Capitulino
next prev parent reply other threads:[~2007-03-17 20:13 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 4:24 Libification project (SoC) Luiz Fernando N. Capitulino
2007-03-16 4:59 ` Shawn O. Pearce
2007-03-16 5:30 ` Junio C Hamano
2007-03-16 6:00 ` Shawn O. Pearce
2007-03-16 6:54 ` Junio C Hamano
2007-03-16 11:54 ` Johannes Schindelin
2007-03-16 13:09 ` Rocco Rutte
2007-03-16 15:12 ` Johannes Schindelin
2007-03-16 15:55 ` Nicolas Pitre
2007-03-16 16:13 ` Johannes Schindelin
2007-03-16 16:26 ` Nicolas Pitre
2007-03-16 18:22 ` Steve Frécinaux
2007-03-16 18:53 ` Nicolas Pitre
2007-03-18 13:57 ` Petr Baudis
2007-03-16 23:26 ` Johannes Schindelin
2007-03-16 16:17 ` Shawn O. Pearce
2007-03-16 18:20 ` Marco Costalba
2007-03-16 18:38 ` Marco Costalba
2007-03-16 18:59 ` Nicolas Pitre
2007-03-16 21:07 ` Marco Costalba
2007-03-16 23:24 ` Johannes Schindelin
2007-03-17 7:04 ` Marco Costalba
2007-03-17 17:29 ` Johannes Schindelin
2007-03-16 19:09 ` Andy Parkins
2007-03-18 14:08 ` Petr Baudis
2007-03-18 23:48 ` Johannes Schindelin
2007-03-19 1:21 ` Petr Baudis
2007-03-19 1:43 ` Johannes Schindelin
2007-03-19 2:56 ` Theodore Tso
2007-03-19 3:55 ` Shawn O. Pearce
2007-03-19 14:57 ` Johannes Schindelin
2007-03-19 16:28 ` Linus Torvalds
2007-03-19 16:32 ` Linus Torvalds
2007-03-21 11:17 ` Andreas Ericsson
2007-03-21 17:24 ` Linus Torvalds
2007-03-22 9:51 ` Andreas Ericsson
2007-03-19 7:01 ` Marco Costalba
2007-03-19 9:46 ` Steve Frécinaux
2007-03-19 10:33 ` Steve Frécinaux
2007-03-19 12:37 ` Johannes Schindelin
2007-03-19 12:52 ` Petr Baudis
2007-03-19 13:55 ` Johannes Schindelin
2007-03-19 13:04 ` Marco Costalba
2007-03-16 12:53 ` Petr Baudis
2007-03-16 13:47 ` Luiz Fernando N. Capitulino
2007-03-16 14:08 ` Petr Baudis
2007-03-16 18:38 ` Luiz Fernando N. Capitulino
2007-03-16 23:16 ` Shawn O. Pearce
2007-03-17 19:58 ` Luiz Fernando N. Capitulino [this message]
2007-03-18 5:23 ` Shawn O. Pearce
2007-03-18 5:52 ` Junio C Hamano
2007-03-18 16:18 ` Luiz Fernando N. Capitulino
2007-03-18 19:31 ` Junio C Hamano
2007-03-19 16:09 ` Luiz Fernando N. Capitulino
2007-03-18 21:15 ` Nicolas Pitre
2007-03-16 15:16 ` Johannes Schindelin
2007-03-16 8:06 ` Johannes Sixt
2007-03-16 8:58 ` Matthieu Moy
2007-03-16 11:51 ` Johannes Schindelin
2007-03-16 12:55 ` Petr Baudis
2007-03-17 2:24 ` Jakub Narebski
2007-03-17 5:22 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070317195832.2af87c06@home.brethil \
--to=lcapitulino@mandriva.com.br \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=pasky@suse.cz \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).