* Re: [PATCH 0/1] banned.h: fix vsprintf warning
2019-08-26 18:33 ` Jeff King
@ 2019-08-26 18:40 ` Taylor Blau
2019-08-27 19:46 ` Junio C Hamano
2019-08-26 19:06 ` Andrey Portnoy
2019-08-26 20:08 ` Andrey Portnoy
2 siblings, 1 reply; 8+ messages in thread
From: Taylor Blau @ 2019-08-26 18:40 UTC (permalink / raw)
To: Jeff King
Cc: Junio C Hamano, Andrey Portnoy, Taylor Blau,
Andrey Portnoy via GitGitGadget, git
On Mon, Aug 26, 2019 at 02:33:17PM -0400, Jeff King wrote:
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
> > "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >
> > > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > > expected.
> >
> > Good eyes. Thanks.
>
> There's an identical patch in:
>
> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
Thanks for mentioning. I did send mine in around a day ago now, but it
came in on a Sunday, so it makes sense that Andrey's message may have
appeared earlier in mailboxes when looking today.
I don't really mind about the credit, nor do I think there's much value
in crediting you or me with 'Racily-implemented-by'. My patch has a few
more details such as blame information (and how the typo was only made
in the explicit version, not the variadic form), so it may be worthwhile
to take that instead of this, but I don't mind either way.
> and both were inspired by:
>
> https://news.ycombinator.com/item?id=20793298
Indeed. It was a little surprising to see 'banned.h' at the top of
Hacker News when I checked it this weekend :-).
> whose author has little info there, but I think is separate from either
> submitter.
>
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
>
> Anyway, the original bug is mine and the patch is obviously correct.
>
> -Peff
Yep.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] banned.h: fix vsprintf warning
2019-08-26 18:40 ` Taylor Blau
@ 2019-08-27 19:46 ` Junio C Hamano
0 siblings, 0 replies; 8+ messages in thread
From: Junio C Hamano @ 2019-08-27 19:46 UTC (permalink / raw)
To: Taylor Blau
Cc: Jeff King, Andrey Portnoy, Andrey Portnoy via GitGitGadget, git
Taylor Blau <me@ttaylorr.com> writes:
> ... My patch has a few
> more details such as blame information (and how the typo was only made
> in the explicit version, not the variadic form), so it may be worthwhile
> to take that instead of this, but I don't mind either way.
Yup, that was exactly why I took that version (after tentatively
queuing the other one, but discarded before pushing the integration
result out).
Thanks, all.
>> I don't know if we want to try to spread credit around via trailers.
>> "Racily-implemented-by:" ? :)
Please don't X-<.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] banned.h: fix vsprintf warning
2019-08-26 18:33 ` Jeff King
2019-08-26 18:40 ` Taylor Blau
@ 2019-08-26 19:06 ` Andrey Portnoy
2019-08-26 20:08 ` Andrey Portnoy
2 siblings, 0 replies; 8+ messages in thread
From: Andrey Portnoy @ 2019-08-26 19:06 UTC (permalink / raw)
To: Jeff King
Cc: Junio C Hamano, Taylor Blau, Andrey Portnoy via GitGitGadget, git
> On Aug 26, 2019, at 11:33 AM, Jeff King <peff@peff.net> wrote:
>
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
>> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>>
>> Good eyes. Thanks.
>
> There's an identical patch in:
>
> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
>
> and both were inspired by:
>
> https://news.ycombinator.com/item?id=20793298
Nope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.
>
> whose author has little info there, but I think is separate from either
> submitter.
>
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
>
> Anyway, the original bug is mine and the patch is obviously correct.
>
> -Peff
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] banned.h: fix vsprintf warning
2019-08-26 18:33 ` Jeff King
2019-08-26 18:40 ` Taylor Blau
2019-08-26 19:06 ` Andrey Portnoy
@ 2019-08-26 20:08 ` Andrey Portnoy
2 siblings, 0 replies; 8+ messages in thread
From: Andrey Portnoy @ 2019-08-26 20:08 UTC (permalink / raw)
Cc: git
> On Aug 26, 2019, at 11:33 AM, Jeff King <peff@peff.net> wrote:
>
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
>> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>>
>> Good eyes. Thanks.
>
> There's an identical patch in:
>
> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
>
> and both were inspired by:
>
> https://news.ycombinator.com/item?id=20793298
Nope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.
>
> whose author has little info there, but I think is separate from either
> submitter.
>
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
>
> Anyway, the original bug is mine and the patch is obviously correct.
>
> -Peff
>
^ permalink raw reply [flat|nested] 8+ messages in thread