sox-users@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
* doxygen
@ 2020-08-11 16:25 Jan Stary
  2020-08-11 16:54 ` doxygen Måns Rullgård
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Stary @ 2020-08-11 16:25 UTC (permalink / raw)
  To: sox-users

There is a Doxyfile (last touched 2011) that nothing seems to use.
There is also this in src/sox.h:

#ifndef _DOXYGEN_
lsx_static_assert(sizeof(sox_int8_t)==1,   sox_int8_size);
lsx_static_assert(sizeof(sox_uint8_t)==1,  sox_uint8_size);
lsx_static_assert(sizeof(sox_int16_t)==2,  sox_int16_size);
lsx_static_assert(sizeof(sox_uint16_t)==2, sox_uint16_size);
lsx_static_assert(sizeof(sox_int32_t)==4,  sox_int32_size);
lsx_static_assert(sizeof(sox_uint32_t)==4, sox_uint32_size);
lsx_static_assert(sizeof(sox_int64_t)==8,  sox_int64_size);
lsx_static_assert(sizeof(sox_uint64_t)==8, sox_uint64_size);
#endif

What does sizeof(int) have to do with using DOXYGEN (or not)?
Can we remove these please?

Jan



_______________________________________________
Sox-users mailing list
Sox-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-users

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: doxygen
  2020-08-11 16:25 doxygen Jan Stary
@ 2020-08-11 16:54 ` Måns Rullgård
  0 siblings, 0 replies; 2+ messages in thread
From: Måns Rullgård @ 2020-08-11 16:54 UTC (permalink / raw)
  To: Jan Stary; +Cc: sox-users

Jan Stary <hans@stare.cz> writes:

> There is a Doxyfile (last touched 2011) that nothing seems to use.

Wouldn't Doxygen use it if someone were to run it?  Can't speak for the
quality of the output it might produce, though.

> There is also this in src/sox.h:
>
> #ifndef _DOXYGEN_
> lsx_static_assert(sizeof(sox_int8_t)==1,   sox_int8_size);
> lsx_static_assert(sizeof(sox_uint8_t)==1,  sox_uint8_size);
> lsx_static_assert(sizeof(sox_int16_t)==2,  sox_int16_size);
> lsx_static_assert(sizeof(sox_uint16_t)==2, sox_uint16_size);
> lsx_static_assert(sizeof(sox_int32_t)==4,  sox_int32_size);
> lsx_static_assert(sizeof(sox_uint32_t)==4, sox_uint32_size);
> lsx_static_assert(sizeof(sox_int64_t)==8,  sox_int64_size);
> lsx_static_assert(sizeof(sox_uint64_t)==8, sox_uint64_size);
> #endif
>
> What does sizeof(int) have to do with using DOXYGEN (or not)?

I have no idea.

> Can we remove these please?

It's relatively harmless.  I want to focus on cleaning up things that
make maintenance difficult first.

-- 
Måns Rullgård


_______________________________________________
Sox-users mailing list
Sox-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-users

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-11 16:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 16:25 doxygen Jan Stary
2020-08-11 16:54 ` doxygen Måns Rullgård

sox-users@lists.sourceforge.net unofficial mirror

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/sox-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 sox-users sox-users/ https://public-inbox.org/sox-users \
		sox-users@lists.sourceforge.net
	public-inbox-index sox-users

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.audio.sox
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.audio.sox
	nntp://news.gmane.io/gmane.comp.audio.sox
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/sox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git