From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 79F5A1F66E for ; Tue, 11 Aug 2020 14:26:06 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5VDz-0001Yr-GS; Tue, 11 Aug 2020 14:25:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5VDy-0001Yj-Gh for sox-users@lists.sourceforge.net; Tue, 11 Aug 2020 14:25:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qq7CnXrrlcgkaQh59zSJua13rQuvvVjTeTsT1E/jg5Y=; b=JnsQrTz0JFQm+hRyd9htx5UM0j VD+QECT+fP4cEw1n859VoU9FfqaaI1Ur9eC6jdc9LrEamdB7Avf/oOy10NvRynicS65/bP9wsNGJw XpoLJ7hy4r7Sn1zVN+2NomxluqDtz0+1iwzWbb90jUDiZUbboNHvuXkudxO15V9Qmtqc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qq7CnXrrlcgkaQh59zSJua13rQuvvVjTeTsT1E/jg5Y=; b=BsUfP0DeE97AVcD9CufS42Ev7u yAEPBCz5d/cjPFigtU/kBr/MF3KPrWIXt/bhSyrijJ78FWnadagJcrixkO54NNSz6lxd47C0N4AP9 1CRCrfUqa4P2ADbv7ceMG9BPuvCmOsZ4lk/JyqNJTY5ciqjaZHFJIkdq29syZ1DbY9r8=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5VDu-001DL7-Eb for sox-users@lists.sourceforge.net; Tue, 11 Aug 2020 14:25:58 +0000 Received: from raven.mansr.com (raven.mansr.com [81.2.72.235]) by unicorn.mansr.com (Postfix) with ESMTPS id EB80215360; Tue, 11 Aug 2020 15:25:36 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id E901A21A6F2; Tue, 11 Aug 2020 15:25:36 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jan Stary References: <20200811141209.GA9040@www.stare.cz> Date: Tue, 11 Aug 2020 15:25:36 +0100 In-Reply-To: <20200811141209.GA9040@www.stare.cz> (Jan Stary's message of "Tue, 11 Aug 2020 16:12:09 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1k5VDu-001DL7-Eb Subject: Re: symlinks X-BeenThere: sox-users@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-users@lists.sourceforge.net Cc: sox-users@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-users-bounces@lists.sourceforge.net Jan Stary writes: > I am confused by the following commit: > > commit fc20c26b2500acb6690f03d610d406bffb8944a9 > Author: Mans Rullgard > Date: Mon Aug 10 21:38:11 2020 +0100 > > build: fix symlink selection > > The configure test whether to enable the play/rec links is broken, > and the makefile uses the same condition for both play/rec and soxi. > Fix both problems. > > diff --git a/configure.ac b/configure.ac > index 9f55b5f8..12af65b0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -647,13 +647,13 @@ AC_MSG_RESULT($enable_symlinks) > enable_playrec_symlinks=3Dno > if test "$enable_symlinks" =3D "yes"; then > SYMLINKS=3Dyes > - if test false \ > - -o "$enable_alsa" =3D yes \ > - -o "$enable_ao" =3D yes \ > - -o "$enable_coreaudio" =3D yes \ > - -o "$enable_oss" =3D yes \ > - -o "$enable_pulseaudio" =3D yes \ > - -o "$enable_sndio" =3D yes \ > + if test "" \ > + -o "$using_alsa" =3D yes \ > + -o "$using_ao" =3D yes \ > + -o "$using_coreaudio" =3D yes \ > + -o "$using_oss" =3D yes \ > + -o "$using_pulseaudio" =3D yes \ > + -o "$using_sndio" =3D yes \ > ; then > PLAYRECLINKS=3Dyes > enable_playrec_symlinks=3Dyes > > How is using alsa/oss/sndio/whatever > related to creating symlinks (or not)? > > Why do we have both SYMLINKS and PLAYRECLINKS? > Why is this different for play/rec vs soxi (also below)? > > Naively, I would assume we want to create symlinks > for each of play, rec, soxi, or none of them. There is no point in creating play/rec symlinks when no audio devices are supported since they can't work then. -- = M=E5ns Rullg=E5rd _______________________________________________ Sox-users mailing list Sox-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-users