unofficial mirror
 help / color / mirror / Atom feed
From: "Måns Rullgård" <>
To: Jeremy Nicoll - ml sox users <>
Subject: Re: Reason for sox mix restriction to two or more input files?
Date: Sat, 10 Aug 2019 18:28:43 +0100
Message-ID: <> (raw)
In-Reply-To: <> (Jeremy Nicoll's message of "Sat, 10 Aug 2019 10:52:54 +0100")

Jeremy Nicoll - ml sox users <> writes:

> On 2019-08-09 20:42, Dr. Thomas Tensi wrote:
>> Dear all,
>> I am using sox for automatic, scripted file generation.
>> One step is a mix of several input files.  It may happen
>> that - by configuration - only a single input file remains
>> for that mixing step.
>> This cannot be handled by sox, because sox _requires_
>> at least two input files and quits with the message
>>   "Not enough input filenames specified"
>> I understand that at least one input file is necessary
>> (for finding the target length, sample rate etc.), but
>> why does sox fail when mixing a single input file?
> Probably because it's simpler to write programmes that assume
> the user means what they say.  So if you ask sox to mix several
> files, it is written assuming that you will provide more than
> one.

There doesn't seem to be any good reason for this.  The below patch
removes the restriction and doesn't seem to break anything based on a
quick test.

diff --git a/src/sox.c b/src/sox.c
index 0b103e269092..39533bac831d 100644
--- a/src/sox.c
+++ b/src/sox.c
@@ -2924,7 +2924,7 @@ int main(int argc, char **argv)
     combine_method = sox_concatenate;
   /* Make sure we got at least the required # of input filenames */
-  if (input_count < (size_t)(is_serial(combine_method) ? 1 : 2))
+  if (input_count < 1)
     usage("Not enough input filenames specified");
   /* Check for misplaced input/output-specific options */

Måns Rullgård

Sox-users mailing list

  parent reply	other threads:[~2019-08-10 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 19:42 Dr. Thomas Tensi
2019-08-10  9:52 ` Jeremy Nicoll - ml sox users
2019-08-10 12:06   ` Dr. Thomas Tensi
2019-08-10 17:28   ` Måns Rullgård [this message]
2019-08-11 19:22 Dr. Thomas Tensi
2019-08-12  9:29 ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link unofficial mirror

This inbox may be cloned and mirrored by anyone:

	git clone --mirror

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 sox-users sox-users/ \
	public-inbox-index sox-users

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone