14.4.2rc2 segfaults on remote OGGs

14.4.2rc2 segfaults on remote OGGs

[Jan Stary]

This is 14.4.2rc2 on OpenBSD/amd64.
play(1) segfaults on each of the following:

http://amp.cesnet.cz:8000/cro-d-dur.flac
http://amp.cesnet.cz:8000/cro-d-dur.ogg
http://amp.cesnet.cz:8000/cro2.ogg
http://amp.cesnet.cz:8000/cro3.ogg
http://amp.cesnet.cz:8000/cro-plus.ogg
http://amp.cesnet.cz:8000/cro-radio-junior.ogg

Remote mp3's play fine though, local ogg's too.
Is this a known bug?

	Jan


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/

Re: 14.4.2rc2 segfaults on remote OGGs

[Eric Wong]

Jan Stary <hans@stare.cz> wrote:
> This is 14.4.2rc2 on OpenBSD/amd64.
> play(1) segfaults on each of the following:
> 
> http://amp.cesnet.cz:8000/cro-d-dur.flac
> http://amp.cesnet.cz:8000/cro-d-dur.ogg
> http://amp.cesnet.cz:8000/cro2.ogg
> http://amp.cesnet.cz:8000/cro3.ogg
> http://amp.cesnet.cz:8000/cro-plus.ogg
> http://amp.cesnet.cz:8000/cro-radio-junior.ogg
> 
> Remote mp3's play fine though, local ogg's too.
> Is this a known bug?

I can't reproduce it on my Linux machine.
Can you show more info? (-V99 / core dump + backtrace)

sox uses wget by default, but doesn't it use ftp(1) on OpenBSD?
Maybe that triggered a bug somewhere...

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/

Re: 14.4.2rc2 segfaults on remote OGGs

[Jan Stary]

On Feb 12 04:31:11, normalperson@yhbt.net wrote:
> Jan Stary <hans@stare.cz> wrote:
> > This is 14.4.2rc2 on OpenBSD/amd64.
> > play(1) segfaults on each of the following:
> > 
> > http://amp.cesnet.cz:8000/cro-d-dur.flac
> > http://amp.cesnet.cz:8000/cro-d-dur.ogg
> > http://amp.cesnet.cz:8000/cro2.ogg
> > http://amp.cesnet.cz:8000/cro3.ogg
> > http://amp.cesnet.cz:8000/cro-plus.ogg
> > http://amp.cesnet.cz:8000/cro-radio-junior.ogg
> > 
> > Remote mp3's play fine though, local ogg's too.
> > Is this a known bug?
> 
> I can't reproduce it on my Linux machine.
> Can you show more info? (-V99 / core dump + backtrace)

$ play -V6 http://amp.cesnet.cz:8000/cro3.ogg  
play DBUG sox: Looking for a default device: trying format `sndio'
play:      SoX v14.4.2
time:     Feb  9 2015 17:30:50
uname:    OpenBSD lenovo.stare.cz 5.7 GENERIC.MP#2 amd64
compiler: gcc 4.2.1 20070719 
arch:     1288 48 88 L 
play INFO formats: detected file format type `vorbis'
Segmentation fault (core dumped) 

> sox uses wget by default, but doesn't it use ftp(1) on OpenBSD?
> Maybe that triggered a bug somewhere...

The OpenBSD port of SoX that uses ftp instead of wget; however,
this is `vanilla' SoX as distributed in the 14.4.2rc2 tarball.

	Jan


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/

Re: 14.4.2rc2 segfaults on remote OGGs

[Jan Stary]

> The OpenBSD port of SoX that uses ftp instead of wget; however,
> this is `vanilla' SoX as distributed in the 14.4.2rc2 tarball.

I mean, the source code gets patched when building the OpenBSD port
(see diff below); it's not like ./configure picks ftp(1) on systems
that have it.

	Jan


$OpenBSD: patch-src_formats_c,v 1.5 2014/12/24 12:31:23 sthen Exp $
--- src/formats.c.orig	Sun Jan 13 19:57:39 2013
+++ src/formats.c	Wed Dec 24 12:30:53 2014
@@ -349,7 +349,7 @@ static int sox_checkformat(sox_format_t * ft)
   return SOX_SUCCESS;
 }
 
-static sox_bool is_url(char const * text) /* detects only wget-supported URLs */
+static sox_bool is_url(char const * text)
 {
   return !(
       strncasecmp(text, "http:" , (size_t)5) &&
@@ -386,7 +386,7 @@ static FILE * xfopen(char const * identifier, char con
   else if (is_url(identifier)) {
     FILE * f = NULL;
 #ifdef HAVE_POPEN
-    char const * const command_format = "wget --no-check-certificate -q -O- \"%s\"";
+    char const * const command_format = "ftp -a -V -o - \"%s\"";
     char * command = lsx_malloc(strlen(command_format) + strlen(identifier));
     sprintf(command, command_format, identifier);
     f = popen(command, POPEN_MODE);

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/

Re: 14.4.2rc2 segfaults on remote OGGs

[Eric Wong]

Jan Stary <hans@stare.cz> wrote:
> Segmentation fault (core dumped) 

Any backtrace from gdb?  I suggest compiling with -ggdb3 to get
as much debug info as possible.

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/