Re: 14.4.2rc2 segfaults on remote OGGs

[Jan Stary <hans@stare.cz>]

> The OpenBSD port of SoX that uses ftp instead of wget; however,
> this is `vanilla' SoX as distributed in the 14.4.2rc2 tarball.

I mean, the source code gets patched when building the OpenBSD port
(see diff below); it's not like ./configure picks ftp(1) on systems
that have it.

	Jan


$OpenBSD: patch-src_formats_c,v 1.5 2014/12/24 12:31:23 sthen Exp $
--- src/formats.c.orig	Sun Jan 13 19:57:39 2013
+++ src/formats.c	Wed Dec 24 12:30:53 2014
@@ -349,7 +349,7 @@ static int sox_checkformat(sox_format_t * ft)
   return SOX_SUCCESS;
 }
 
-static sox_bool is_url(char const * text) /* detects only wget-supported URLs */
+static sox_bool is_url(char const * text)
 {
   return !(
       strncasecmp(text, "http:" , (size_t)5) &&
@@ -386,7 +386,7 @@ static FILE * xfopen(char const * identifier, char con
   else if (is_url(identifier)) {
     FILE * f = NULL;
 #ifdef HAVE_POPEN
-    char const * const command_format = "wget --no-check-certificate -q -O- \"%s\"";
+    char const * const command_format = "ftp -a -V -o - \"%s\"";
     char * command = lsx_malloc(strlen(command_format) + strlen(identifier));
     sprintf(command, command_format, identifier);
     f = popen(command, POPEN_MODE);

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/