From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4D2361F66E for ; Tue, 11 Aug 2020 13:58:51 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Unh-0002yr-3t; Tue, 11 Aug 2020 13:58:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Ung-0002yj-1s for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 13:58:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E1SMIgztyci9jCxlzFS3wSSkKHcm3tTUHQn7hinY1Es=; b=CMxirxefFzKUbhtFooj5lJ5wbn XZe1Oi297Y6Yq9PQTx8KYjC71X9B4K7hz25Vf3annlr6vOacsEHThkmbZVIx9TFIFTknIYx36zvdX 0x4b+uZvnAYjv0QWMN3fTHMzW1D/VuzAFrdxUntONk5MSmvrUcutJvHkQJNCTwEQ2wjU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=E1SMIgztyci9jCxlzFS3wSSkKHcm3tTUHQn7hinY1Es=; b=DUArkclhEu3FC14MvYWprrsSiP CvczZAEPXwPm4b5CScvFIbRCpGafnR1ICRliMKV0w0ngMKCVvxvSryABBeTbKPzNfozMuN/gqAdz/ 6QzWNI1wYAHUmEcyvh5CQUbU38VtiX4atWkbA97zrofwdOgmdPfwpmsjEHTvnC9NZRYo=; Received: from [81.2.72.234] (helo=unicorn.mansr.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5Unc-005s3Z-3W for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 13:58:48 +0000 Received: from raven.mansr.com (raven.mansr.com [81.2.72.235]) by unicorn.mansr.com (Postfix) with ESMTPS id 6600A15360; Tue, 11 Aug 2020 14:58:20 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 2C4A521A6F2; Tue, 11 Aug 2020 14:58:20 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jan Stary References: <20200810121707.29623-1-mans@mansr.com> <20200811133407.GA88171@www.stare.cz> Date: Tue, 11 Aug 2020 14:58:20 +0100 In-Reply-To: <20200811133407.GA88171@www.stare.cz> (Jan Stary's message of "Tue, 11 Aug 2020 15:34:07 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1k5Unc-005s3Z-3W Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Jan Stary writes: > This is OpenBSD/current. > > On Aug 10 13:17:07, mans@mansr.com wrote: >> Near as I can tell, no system actually has a machine/soundcard.h file. > > OpenBSD has neither nor ; > it has , as documented in http://man.openbsd.org/ossaudio Right, and we don't want it anyway. >> The libossaudio library on NetBSD and OpenBSD is meant to emulate a >> few ioctl() commands to facilitate porting of Linux applications. > > Yes. > >> As we have proper sndio support, this is of no use for SoX. > > On OpenBSD, yes (I will look at NetBSD and FreeBSD in separate emails). > Current SoX git builds and runs fine on OpenBSD > (except the recent -Wl,--as-needed) using sndio, > if ./configure'd right. The OpenBSD port of SoX 14.4.2 > http://cvsweb.openbsd.org/ports/audio/sox/Makefile?rev=3D1.72 > explicitly builds --without-oss --without-sunaudio --with-sndio > > In fact, these options are necessary (that is to say, > the autodetection is broken); when ./configure'd without options, > it detects each of sndio, ossaudio and sunaudio, and fails with > > sox.c: In function 'adjust_volume': > sox.c:1337: error: 'audio_info_t' undeclared (first use in this function) > sox.c:1337: error: (Each undeclared identifier is reported only once > sox.c:1337: error: for each function it appears in.) > sox.c:1337: error: expected ';' before 'audio_info' > sox.c:1338: error: 'AUDIO_GETINFO' undeclared (first use in this function) > sox.c:1338: error: 'audio_info' undeclared (first use in this function) > sox.c:1341: warning: implicit declaration of function 'AUDIO_INITINFO' > sox.c:1345: error: 'AUDIO_SETINFO' undeclared (first use in this function) > > (These are artifacts of sunaudio, right?) That's what it looks like. Does OpenBSD have an audioio.h file for some other purpose? > A naive 'grep -Fr audio_info_t .' reveals that SoX ships with > > src/bit-rot/ > src/bit-rot/CoreAudio > src/bit-rot/CoreAudio/CoreAudio.h > src/bit-rot/mmreg.h > src/bit-rot/mmsystem.h > src/bit-rot/sndio.h > src/bit-rot/sys > src/bit-rot/sys/audioio.h > src/bit-rot/windows.h > > What are these for? Probably to compile-test the related source files on other systems. >> --- >> Are there any BSD users here who can comment on this? >> --- >> configure.ac | 5 +---- >> src/oss.c | 3 --- >> 2 files changed, 1 insertion(+), 7 deletions(-) >> = >> diff --git a/configure.ac b/configure.ac >> index b1440560181c..9f55b5f8a55c 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -609,10 +609,7 @@ AC_OPTIONAL_FORMAT(sndfile, SNDFILE, [using_sndfile= =3D$tmp_using_sndfile]) >> = >> = >> = >> -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, >> - [AC_CHECK_HEADERS(machine/soundcard.h, >> - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS=3D"$OSS_LIBS -lossaudio= ")], >> - using_oss=3Dno)])]) >> +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_o= ss=3Dno)]) > > Apparently, the presence of is not > a correct test of ossaudio being available in the system. > > 'uing_oss' is a typo I guess. Yes, sorry about that. Does it still mis-detect it with that fixed? > (God I hate autotools.) I hate cmake more. -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel