Re: Review/merge request - RSO/RSF support

["Måns Rullgård" <mans@mansr.com>]

Jakub Vaněk <linuxtardis@gmail.com> writes:

> Hi all,
>
> I've created a patch for supporting for the NXT RSO / EV3 RSF (Robot
> Sound File) format. It is a format used on the stock firmware of the
> LEGO NXT and EV3 programmable bricks. I thought that it would be nice
> to have native support in SoX.
>
> The format is capable of holding U8 PCM or ADPCM samples. Currently
> decoding of both formats is implemented. However for encoding I have
> disabled the ADPCM support, because the created files sound very wrong
> on the real brick. U8 PCM mode on the other hand works well.
>
> RSO support is implemented also in FFmpeg, just the RSF alias isn't.
>
> I am posting the exported commit below. However, it is also available
> from GitHub: https://github.com/JakubVanek/sox-rsf/commit/f906852451a2efc5b1129c7b34bfc378d3f4da62.patch

Is there a specification, preferably official, for this format available
somewhere?  Could you provide a few samples?

> diff --git a/src/rso.c b/src/rso.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..92256d130c63f79d1a8eb6ddf5db4197796b5f6b
> --- /dev/null
> +++ b/src/rso.c
> @@ -0,0 +1,233 @@
> +/* (c) 2019 SoX contributors

Please use your actual name in copyright tags.  If non-trivial portions
of the code were written by someone else, they should also be mentioned,
along with some kind of assurance that they approve of the distribution
under the specified licence terms (LGPL).

I will not touch patches lacking clear provenance.

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel