stdint

stdint

[Jan Stary]

The latest commit says

    All modern systems, even msvc, have the C99 stdint.h integer types.
    Replace the guesswork with typedefs using these types.  This fixes
    numerous warnings on some system where both long and long long are
    64-bit.

and replaces e.g. the following attrocity

  #if SCHAR_MAX==127 && SCHAR_MIN==(-128)
  typedef signed char sox_int8_t;
  #elif CHAR_MAX==127 && CHAR_MIN==(-128)
  typedef char sox_int8_t;
  #else
  #error Unable to determine an appropriate definition for sox_int8_t.
  #endif

with

  typedef int8_t sox_int8_t;

But why typedef standard int types such as int8_t at all?
Why does the code use sox_int8_t (being a typedef of int8_t)
instead of simply using int8_t, as defined in stdint.h?

Jan



_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

Re: stdint

[Måns Rullgård]

Jan Stary <hans@stare.cz> writes:

> The latest commit says
>
>     All modern systems, even msvc, have the C99 stdint.h integer types.
>     Replace the guesswork with typedefs using these types.  This fixes
>     numerous warnings on some system where both long and long long are
>     64-bit.
>
> and replaces e.g. the following attrocity
>
>   #if SCHAR_MAX==127 && SCHAR_MIN==(-128)
>   typedef signed char sox_int8_t;
>   #elif CHAR_MAX==127 && CHAR_MIN==(-128)
>   typedef char sox_int8_t;
>   #else
>   #error Unable to determine an appropriate definition for sox_int8_t.
>   #endif
>
> with
>
>   typedef int8_t sox_int8_t;
>
> But why typedef standard int types such as int8_t at all?
> Why does the code use sox_int8_t (being a typedef of int8_t)
> instead of simply using int8_t, as defined in stdint.h?

SoX predates stdint.h.  It made sense once upon a time.  We can get rid
of those typedefs, but since libsox users might be relying on them, we
should give them a chance to update their code before simply deleting
them.  All in good time.

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel