sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: "Måns Rullgård" <mans@mansr.com>
To: Jan Stary <hans@stare.cz>
Cc: sox-devel@lists.sourceforge.net
Subject: Re: stdint
Date: Fri, 21 Aug 2020 23:05:00 +0100	[thread overview]
Message-ID: <yw1xtuwvmz8z.fsf@mansr.com> (raw)
In-Reply-To: <20200821211633.GA40271@www.stare.cz> (Jan Stary's message of "Fri, 21 Aug 2020 23:16:33 +0200")

Jan Stary <hans@stare.cz> writes:

> The latest commit says
>
>     All modern systems, even msvc, have the C99 stdint.h integer types.
>     Replace the guesswork with typedefs using these types.  This fixes
>     numerous warnings on some system where both long and long long are
>     64-bit.
>
> and replaces e.g. the following attrocity
>
>   #if SCHAR_MAX==127 && SCHAR_MIN==(-128)
>   typedef signed char sox_int8_t;
>   #elif CHAR_MAX==127 && CHAR_MIN==(-128)
>   typedef char sox_int8_t;
>   #else
>   #error Unable to determine an appropriate definition for sox_int8_t.
>   #endif
>
> with
>
>   typedef int8_t sox_int8_t;
>
> But why typedef standard int types such as int8_t at all?
> Why does the code use sox_int8_t (being a typedef of int8_t)
> instead of simply using int8_t, as defined in stdint.h?

SoX predates stdint.h.  It made sense once upon a time.  We can get rid
of those typedefs, but since libsox users might be relying on them, we
should give them a chance to update their code before simply deleting
them.  All in good time.

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

      reply	other threads:[~2020-08-21 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 21:16 stdint Jan Stary
2020-08-21 22:05 ` Måns Rullgård [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw1xtuwvmz8z.fsf@mansr.com \
    --to=sox-devel@lists.sourceforge.net \
    --cc=hans@stare.cz \
    --subject='Re: stdint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).