From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 239BC1F66E for ; Tue, 11 Aug 2020 14:14:42 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5V30-0003iI-PC; Tue, 11 Aug 2020 14:14:38 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5V2z-0003iB-Kf for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 14:14:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LEPJzJw6TZqeqt452ot0Sc4TQozbEys6Gxol8QbMdn8=; b=S4N7NQEViysNy3pOvAbdngKQKF e+CdEft38TI6f/vo7hO59fcr6h1Bma6cvS40glDfPtcn2K99gRGCeeFXMvUUycs9IpS82nTy/dnu2 KvW4hr1MBzb5snrnJPl3XI/MWzP6R1y61EyfFPrtk4XemuDEJKSOoNDcU2szY9gtyWUM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LEPJzJw6TZqeqt452ot0Sc4TQozbEys6Gxol8QbMdn8=; b=FORXta3nSLwyAsd1zwKpgidJon x6N05sC3kpnl+G/i27b9fQOSAFZT2lPWQPQ3pCaNZDY5+g2HpfFzSRPnF7mwYlIXDkPU9QJVm+t0R 1cjHG40meWoebJQdaIVKuNR1pGq1FvOzIO5SO4uXwfgbbSaMAOxtjjAU7HOOSyM50Rx0=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5V2y-005vSN-Ao for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 14:14:37 +0000 Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:8d8e::3]) by unicorn.mansr.com (Postfix) with ESMTPS id 080A715360; Tue, 11 Aug 2020 15:14:30 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id EE5A721A6F2; Tue, 11 Aug 2020 15:14:29 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jan Stary References: <20200810121707.29623-1-mans@mansr.com> <20200811133407.GA88171@www.stare.cz> <20200811134150.GA70131@www.stare.cz> Date: Tue, 11 Aug 2020 15:14:29 +0100 In-Reply-To: <20200811134150.GA70131@www.stare.cz> (Jan Stary's message of "Tue, 11 Aug 2020 15:41:50 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1k5V2y-005vSN-Ao Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Jan Stary writes: >> > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, >> > - [AC_CHECK_HEADERS(machine/soundcard.h, >> > - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS=3D"$OSS_LIBS -lossaud= io")], >> > - using_oss=3Dno)])]) >> > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing= _oss=3Dno)]) >> = >> Apparently, the presence of is not >> a correct test of ossaudio being available in the system. > > Maybe I am confused by the Subject: > "remove check for machine/soundcard.h and libossaudio" The checks for those things have been removed. It now only checks for sys/soundcard.h since that better reflects what we actually want. > It seems this diff does not remove, but change the way > ossaudio is detected; namely, if sys/soundcard.h is present, > we have oss (which is wrong, at least on OpenBSD); Did you fix that typo (a git pull will do it)? If not, it would definitely "detect" it as present on any system. > also, even with oss detected, we no longer set -libossaudio, > which also seems wrong (anywhere we want to use it). -lossaudio is _only_ for the emulation on *BSD. No library is required on systems with real OSS drivers. We shouldn't be using the emulation, so there is no need to link with the library either. -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel