From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 24A861F66E for ; Thu, 27 Aug 2020 11:54:12 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kBGTn-0007ae-7i; Thu, 27 Aug 2020 11:54:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBGTl-0007aT-MT for sox-devel@lists.sourceforge.net; Thu, 27 Aug 2020 11:54:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D+3JelHHOUbt8m6SY/aA2sFq9WJisAjtQAXdlIeA4fU=; b=PJDezdMuOYsM6GZcocXGiyAP31 H1xmfRR9ffDfYkXqiO+C4SGHIssHHUSEYG8aDUp54uS6cWJogXlUGUS96Si+if2uAzZBL/C4hDIYw zoxqEsq7Gfz1oX7nk4PJIXxe8cHy++Dsbmkd6ewiuH+MscLfMpCVUl2GR/fvgbhw9v+0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=D+3JelHHOUbt8m6SY/aA2sFq9WJisAjtQAXdlIeA4fU=; b=Y4AA93UWLy7hTxvyaRYl9W0j8M Tx8i+yfnX3RsZSTnwDdi/Ctt31MA+gfe73dMfbtJH/C3ei/gIPaRzfzq8pJmKCkOqxuXRMIX1qLxD MXrPfeeJMyNPZq7H1c3GDMEukLkC8wmzYA9mVMi8UjWHsf/jcCUdnA9U6qVOSVBXXfZk=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kBGTj-007iJj-0U for sox-devel@lists.sourceforge.net; Thu, 27 Aug 2020 11:54:05 +0000 Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:8d8e::3]) by unicorn.mansr.com (Postfix) with ESMTPS id 7E85515360; Thu, 27 Aug 2020 12:53:46 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 7C0AB21A6F2; Thu, 27 Aug 2020 12:53:46 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jan Stary References: <20200822081738.GA14321@www.stare.cz> <20200822153545.GA61858@www.stare.cz> <20200823140733.GA9403@www.stare.cz> <20200823215551.GA83582@www.stare.cz> <20200824065643.GA91434@www.stare.cz> <20200827094048.GC5768@www.stare.cz> <20200827113729.GA70347@www.stare.cz> Date: Thu, 27 Aug 2020 12:53:46 +0100 In-Reply-To: <20200827113729.GA70347@www.stare.cz> (Jan Stary's message of "Thu, 27 Aug 2020 13:37:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1kBGTj-007iJj-0U Subject: Re: Build system cleanup X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Jan Stary writes: > On Aug 27 12:08:02, mans@mansr.com wrote: >> Jan Stary writes: >> = >> > On Aug 24 08:56:43, hans@stare.cz wrote: >> >> On Aug 23 23:55:51, hans@stare.cz wrote: >> >> > > > cc [...] -o .libs/sox sox.o -L./.libs -lsox -L/usr/local/lib -= lpng [...] >> >> > > > cc [...] -o .libs/sox sox.o -L/usr/local/lib -L./.libs -lsox -= lpng [...] >> >> > > > >> >> > > > The first works, the second does not. >> >> > > > The only difference between the two is the place >> >> > > > where the extra -L/usr/local/lib gets added, >> >> > > > as described in the previous emails. >> >> > = >> >> > And it seems libtool itself is the one who breaks it. >> >> > This is the failing line again: >> >> > = >> >> > /bin/sh ../libtool --tag=3DCC --mode=3Dlink cc -g -O2 -fstack-= protector-strong -Wall -Wmissing-prototypes -Wstrict-prototypes -avoid-ve= rsion -module -L/usr/local/lib -Wl,--as-needed -o sox sox.o libsox.la = -lm >> >> > = >> >> > Notice the "-L/usr/local/lib -Wl,--as-needed". >> >> > The "-L/usr/local/lib" part comes from the configure arg: >> >> > = >> >> > ./configure CC=3Dcc CPPFLAGS=3D-I/usr/local/include LDFLAGS=3D-L/= usr/local/lib >> >> > = >> >> > The "-Wl,--as-needed" comes from >> >> > = >> >> > $ grep as-needed configure.ac >> >> > AX_APPEND_LINK_FLAGS([-Wl,--as-needed]) >> >> > = >> >> > That results in the following line in src/Makefile: >> >> > = >> >> > LDFLAGS =3D -L/usr/local/lib -Wl,--as-needed >> >> > = >> >> > and that's what is passed in the above command line. Now, libtool >> >> > apparently preprocesses the line into something else; in particular, >> >> > it reorders the options. The very next command is: >> >> > = >> >> > libtool: link: cc -g -O2 -fstack-protector-strong -Wall -Wmissing-p= rototypes -Wstrict-prototypes -Wl,--as-needed -o .libs/sox sox.o -L/usr/lo= cal/lib -L./.libs -lsox -lpng -lltdl -lao -lgsm -lmad -lmp3lame -ltwolame -= lid3tag -lz -lopusfile -lopus -lsndio -lvorbisfile -lwavpack -lcrypto -lsnd= file -lFLAC -lvorbisenc -lvorbis -logg -lm -Wl,-rpath,/usr/local/lib >> >> > = >> >> > Notice where the -L/usr/local/lib has been moved. >> >> > As described previously, if it comes after -lsox >> >> > instead of before it, it links just fine. >> >> = >> >> That being said, the same problem is present in the master branch, >> >> but it works in 14.4.2, where the libtool line is >> >> = >> >> bin/sh ../libtool --silent --tag=3DCC --silent --mode=3Dlink cc -W= traditional-co >> >> nversion -g -O2 -fstack-protector -Wall -W -Wmissing-prototypes -Wst= rict-protot >> >> ypes -pedantic -avoid-version -module -L/usr/local/lib -o sox sox.o= libsox.la >> >> -lm >> >> = >> >> which becomes (without 'silent') >> >> = >> >> libtool: link: cc -Wtraditional-conversion -g -O2 -fstack-protector -= Wall -W -Wmissing-prototypes -Wstrict-prototypes -pedantic -o .libs/sox sox= .o -L/usr/local/lib -L./.libs -lsox -lltdl -lpng -lao -lgsm -lmad -lid3tag= -lz -lmp3lame -ltwolame -lopusfile -lopus -lsndio -lvorbisfile -lwavpack -= lcrypto -lsndfile -lFLAC -lvorbisenc -lvorbis -logg -lm -Wl,-rpath,/home/ha= ns/lib -Wl,-rpath,/usr/local/lib >> > >> > Presumably, the problem does not occur wih a release, >> > because it already comes with a ./configure script, >> > so the builder does not have to run autoreconf -i, >> > which is when the (broken) ./libtool gets created. >> > So the 'libtool' called is the OpenBSD libtool, >> > which does not have that bug. >> = >> Unfortunately, that's not the case. The release tarball includes >> whatever libtool script is on the system that generated it. > > Apparently, 14.4.2 does not: > > $ tar xzf /usr/ports/distfiles/sox-14.4.2.tar.gz > $ find sox-14.4.2/ -name libtool It is created by configure from the ltmain.sh script which is included. -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel