From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3561 216.34.176.0/20 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,T_DKIM_INVALID shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7BCD81F42B for ; Wed, 8 Nov 2017 00:53:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1eCEc7-00005O-Ti; Wed, 08 Nov 2017 00:53:07 +0000 Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eCEc6-00005I-Ci for sox-devel@lists.sourceforge.net; Wed, 08 Nov 2017 00:53:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vRrAhJxraRfxZLaFPKbhvZbcqamJ8ILbVXATGxPMjho=; b=G6gPCuh5yaeL+9rxNL5SWcc7n5 fq7TVLatg2mwFymTt2psGc/bhQPpQCmkHSbVgLwsuLGv2/Tus3XT07BMKJTdhrtwT07klTsiA0Hb+ 4DvmZEJbyJ9MgBwQR0T9sWHPkH+RlfHQ20d3D+9yBbB9iHuiFjPnPA14Vcy65lC3t2z4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vRrAhJxraRfxZLaFPKbhvZbcqamJ8ILbVXATGxPMjho=; b=P371I/EemeKHjry1aZOCfV3ozf 88DAxAPNeVK4TmSIp3kxpzB15+ZcfPybzyO4fanHj5neYBgtQSfEN5B4w5iqil5NHi6ssTnS+y5UV Ji1vMKcNpngutIGLdTiQXDhYM0ROzX5CwElapmiSNg99gP01K/p6/b7dBRzvglalnK6k=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-3.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) id 1eCEc2-0004vd-QF for sox-devel@lists.sourceforge.net; Wed, 08 Nov 2017 00:53:06 +0000 Received: by unicorn.mansr.com (Postfix, from userid 51770) id BB35915603; Wed, 8 Nov 2017 00:52:56 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Eric Wong References: <20171108002914.782-1-mans@mansr.com> <20171108004217.GA18760@starla> Date: Wed, 08 Nov 2017 00:52:56 +0000 In-Reply-To: <20171108004217.GA18760@starla> (Eric Wong's message of "Wed, 8 Nov 2017 00:42:17 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1eCEc2-0004vd-QF Subject: Re: [PATCH] adpcm: fix stack overflow with >4 channels (CVE-2017-15372) X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Eric Wong writes: > Mans Rullgard wrote: >> --- a/src/adpcm.h >> +++ b/src/adpcm.h >> @@ -29,8 +29,11 @@ >> /* default coef sets */ >> extern const short lsx_ms_adpcm_i_coef[7][2]; >> = >> +extern void *lsx_ms_adpcm_alloc(unsigned chans); >> + >> /* lsx_ms_adpcm_block_expand_i() outputs interleaved samples into one o= utput buffer */ >> extern const char *lsx_ms_adpcm_block_expand_i( >> + void *priv, >> unsigned chans, /* total channels */ >> int nCoef, >> const short *coef, > > Thanks, seems fine; though I'd probably export an opaque struct > which makes the unsigned chans arg redundant. Do you mean to store the number of channels as well as the state buffer in a struct? > I'm a little concerned about the internal API changes like this > affecting some 3rd-party code somewhere; but I guess we limit > our exports nowadays (ugh, and that export regexp is nasty) These functions aren't exported, and the supported interface is whatever is in sox.h, nothing else. -- = M=E5ns Rullg=E5rd ---------------------------------------------------------------------------= --- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel