From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 970F01F66E for ; Tue, 11 Aug 2020 14:39:38 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5VR7-000141-PX; Tue, 11 Aug 2020 14:39:33 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5VR6-00013i-51 for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 14:39:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MpoQTLaIY7OUri1yr/Z1P+pDo9knNdodEuKb0OO9OdY=; b=dc4+E+wAvv9pH0W7Mpa/JYhFJf IRrXHJX37D3np18iWuFi+hoHH75LIl8Me+7J0+FOU3//iBHAx1Qs55tBtFdkjGaCXQYqUxnVtQinc VZgHl6DQ80jxOcIM3Y+NNLOeVKgfTQn9Gbjl7qpa1Vm5RKvfkFqr0eGtIQ4NH3+vQd18=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MpoQTLaIY7OUri1yr/Z1P+pDo9knNdodEuKb0OO9OdY=; b=dXMFcRpIjspgV55+9OU42LpNqZ VGVPt6CgKlzrMiilzDzLYlj8BX8TGtAnNwR877HC6vmIl0AoScf8vF3wPhNIWkP/jt2QLKH1Ja2e3 afLZO7hV4L1iYe4/VXWUblbVev+P/OkXLMAQULtS45t8QuR5LD1Mio79fkvOPo3iz24M=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5VR4-008san-Qh for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 14:39:32 +0000 Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:8d8e::3]) by unicorn.mansr.com (Postfix) with ESMTPS id A1D6615360; Tue, 11 Aug 2020 15:39:19 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 95FEC21A6F2; Tue, 11 Aug 2020 15:39:19 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jan Stary References: <20200810121707.29623-1-mans@mansr.com> <20200811133407.GA88171@www.stare.cz> <20200811134150.GA70131@www.stare.cz> <20200811143338.GB63033@www.stare.cz> Date: Tue, 11 Aug 2020 15:39:19 +0100 In-Reply-To: <20200811143338.GB63033@www.stare.cz> (Jan Stary's message of "Tue, 11 Aug 2020 16:33:38 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1k5VR4-008san-Qh Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Jan Stary writes: > On Aug 11 15:14:29, mans@mansr.com wrote: >> Jan Stary writes: >> = >> >> > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, >> >> > - [AC_CHECK_HEADERS(machine/soundcard.h, >> >> > - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS=3D"$OSS_LIBS -loss= audio")], >> >> > - using_oss=3Dno)])]) >> >> > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, u= ing_oss=3Dno)]) >> >> = >> >> Apparently, the presence of is not >> >> a correct test of ossaudio being available in the system. >> > >> > Maybe I am confused by the Subject: >> > "remove check for machine/soundcard.h and libossaudio" >> = >> The checks for those things have been removed. It now only checks for >> sys/soundcard.h since that better reflects what we actually want. > > Does that mean "if sys/soundcard.h was found, > we are on a system where we want to use OSS"? For want of a more specific test, yes. Maybe we should check for one of the SNDCTL_ macros as well. >> > It seems this diff does not remove, but change the way >> > ossaudio is detected; namely, if sys/soundcard.h is present, >> > we have oss (which is wrong, at least on OpenBSD); >> = >> Did you fix that typo (a git pull will do it)? If not, it would >> definitely "detect" it as present on any system. > > With that typo fixed, ./configure on OpenBSD thinks that > > OPTIONAL DEVICE DRIVERS > ao (Xiph)..................no > alsa (Linux)...............no > coreaudio (Mac OS X).......no > sndio (OpenBSD)............yes > oss........................no > pulseaudio.................no > sunaudio...................yes > waveaudio (MS-Windows).....no > > and the compilatiopn fails as in my previous email. > But ./configure --without-sunaudio results in > > OPTIONAL DEVICE DRIVERS > ao (Xiph)..................no > alsa (Linux)...............no > coreaudio (Mac OS X).......no > sndio (OpenBSD)............yes > oss........................no > pulseaudio.................no > sunaudio...................no > waveaudio (MS-Windows).....no > > and it builds fine. > >> > also, even with oss detected, we no longer set -libossaudio, >> > which also seems wrong (anywhere we want to use it). >> = >> -lossaudio is _only_ for the emulation on *BSD. No library is required >> on systems with real OSS drivers. We shouldn't be using the emulation, >> so there is no need to link with the library either. > > Right; sorry for the confusion. > > Jan > -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel