* WAV reader cleanup
@ 2020-08-08 14:59 Måns Rullgård
2020-08-11 21:48 ` Måns Rullgård
0 siblings, 1 reply; 4+ messages in thread
From: Måns Rullgård @ 2020-08-08 14:59 UTC (permalink / raw)
To: sox-devel
I have done a thorough overhaul of the WAV file reader, fixing several
open bugs as well as some I discovered while working on it. Now any
change of this magnitude is not without risk of breaking something that
used to work. I have tested it on a few thousand WAV files without
observing any unexpected changes. Still, I may have missed something.
The new code is in the 'new-wave' branch in the git repo. Please try it
out, especially if you have any weird WAV files lying around.
--
Måns Rullgård
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: WAV reader cleanup
2020-08-08 14:59 WAV reader cleanup Måns Rullgård
@ 2020-08-11 21:48 ` Måns Rullgård
2020-08-12 4:25 ` Eric Wong
0 siblings, 1 reply; 4+ messages in thread
From: Måns Rullgård @ 2020-08-11 21:48 UTC (permalink / raw)
To: sox-devel
Måns Rullgård <mans@mansr.com> writes:
> I have done a thorough overhaul of the WAV file reader, fixing several
> open bugs as well as some I discovered while working on it. Now any
> change of this magnitude is not without risk of breaking something that
> used to work. I have tested it on a few thousand WAV files without
> observing any unexpected changes. Still, I may have missed something.
>
> The new code is in the 'new-wave' branch in the git repo. Please try it
> out, especially if you have any weird WAV files lying around.
Nobody?
--
Måns Rullgård
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: WAV reader cleanup
2020-08-11 21:48 ` Måns Rullgård
@ 2020-08-12 4:25 ` Eric Wong
2020-08-12 9:30 ` Måns Rullgård
0 siblings, 1 reply; 4+ messages in thread
From: Eric Wong @ 2020-08-12 4:25 UTC (permalink / raw)
To: sox-devel
Måns Rullgård <mans@mansr.com> wrote:
> Måns Rullgård <mans@mansr.com> writes:
>
> > I have done a thorough overhaul of the WAV file reader, fixing several
> > open bugs as well as some I discovered while working on it. Now any
> > change of this magnitude is not without risk of breaking something that
> > used to work. I have tested it on a few thousand WAV files without
> > observing any unexpected changes. Still, I may have missed something.
> >
> > The new code is in the 'new-wave' branch in the git repo. Please try it
> > out, especially if you have any weird WAV files lying around.
>
> Nobody?
I took a quick look at the new-wave branch and didn't notice
anything jump out at me. lsx_read_fields is nice :>
I don't have any WAV files lying around; all my stored files are
FLAC for checksumming. .sox sometimes for temporary stuff, but
usually it's all via pipes.
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: WAV reader cleanup
2020-08-12 4:25 ` Eric Wong
@ 2020-08-12 9:30 ` Måns Rullgård
0 siblings, 0 replies; 4+ messages in thread
From: Måns Rullgård @ 2020-08-12 9:30 UTC (permalink / raw)
To: Eric Wong; +Cc: sox-devel
Eric Wong <normalperson@yhbt.net> writes:
> Måns Rullgård <mans@mansr.com> wrote:
>> Måns Rullgård <mans@mansr.com> writes:
>>
>> > I have done a thorough overhaul of the WAV file reader, fixing several
>> > open bugs as well as some I discovered while working on it. Now any
>> > change of this magnitude is not without risk of breaking something that
>> > used to work. I have tested it on a few thousand WAV files without
>> > observing any unexpected changes. Still, I may have missed something.
>> >
>> > The new code is in the 'new-wave' branch in the git repo. Please try it
>> > out, especially if you have any weird WAV files lying around.
>>
>> Nobody?
>
> I took a quick look at the new-wave branch and didn't notice
> anything jump out at me. lsx_read_fields is nice :>
>
> I don't have any WAV files lying around; all my stored files are
> FLAC for checksumming. .sox sometimes for temporary stuff, but
> usually it's all via pipes.
Thanks for checking it over. It's not easy reading, but hopefully the
code is a bit cleaner now.
--
Måns Rullgård
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-12 9:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-08 14:59 WAV reader cleanup Måns Rullgård
2020-08-11 21:48 ` Måns Rullgård
2020-08-12 4:25 ` Eric Wong
2020-08-12 9:30 ` Måns Rullgård
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).