From: "Måns Rullgård" <mans@mansr.com>
To: fbk-qriry@zacglen.net
Cc: sox-devel@lists.sourceforge.net
Subject: Re: silence additional patch
Date: Sun, 06 Sep 2020 12:23:00 +0100 [thread overview]
Message-ID: <yw1x7dt7i1yj.fsf@mansr.com> (raw)
In-Reply-To: <202009060416.0864GFf8029685.mail.zacglen.com@localhost> (fbk-qriry@zacglen.net's message of "Sun, 6 Sep 2020 14:16:15 +1000")
fbk-qriry@zacglen.net writes:
> Further to my previous "silence" patch I have discovered
> that there is another error involving the rms calculations.
>
> Initially, and after a reset, the rms sample window is empty
> yet the rms calculation always uses the window size as
> the calculation denominator. This will make the rms
> value appear artificially low to start with. Instead, an
> actual count of samples should be used.
>
> Incidentally, I think that the hard-coded 1/50 for selection
> of a window size should also be parametized. Sometimes a size using
> 1/20 (100 milliseconds when stereo) can be more appropriate than the
> very small 40 millisecond hard-coded sample window size.
>
> The following is the updated patch:
I'm certainly not going to take a patch with several unrelated changes
as is, nor am I going to do the work unravelling what's what.
--
Måns Rullgård
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
next prev parent reply other threads:[~2020-09-06 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 4:16 silence additional patch fbk-qriry
2020-09-06 11:23 ` Måns Rullgård [this message]
2020-09-06 11:50 ` fbk-qriry
2020-09-06 12:45 ` Måns Rullgård
2020-09-06 12:50 ` fbk-qriry
2020-09-06 14:00 ` Cary Lewis
2020-09-07 11:32 ` Måns Rullgård
2020-09-06 11:58 ` fbk-qriry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.sourceforge.net/lists/listinfo/sox-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x7dt7i1yj.fsf@mansr.com \
--to=sox-devel@lists.sourceforge.net \
--cc=fbk-qriry@zacglen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).