From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CEA641F66E for ; Wed, 12 Aug 2020 09:31:09 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5n67-0001he-9C; Wed, 12 Aug 2020 09:31:03 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5n65-0001h9-JX for sox-devel@lists.sourceforge.net; Wed, 12 Aug 2020 09:31:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=26HAbafSjWkZPA4e+HOCQMwzf0PF4PO3uXUmcANrKPY=; b=EBOHtmLdG4fpCCk6z8xIjnUegz d7sxF/LLaNhTUDrPsfNF8br8erNWM+8amiG8/BeEfIdlacwaDijtYNNj4T2Fw6PqcOCRZfQtBJq+W lVAeCqlr60JIm0qX/ortuM7a1kNKI8bGPzOizZNwbuwSZPKtamuFzEtDsqyBiOsxI6P8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=26HAbafSjWkZPA4e+HOCQMwzf0PF4PO3uXUmcANrKPY=; b=AXxscUXZegcuMug1OwGEw+xYk2 Erwik+2nxpCJu3j5bphtBghUq1gUQiJDWR0VRiQ3XAKQYY6uMGkDqv2jt0pEjQQ6GSSGeYMnxgyOk lcNrRWpG8PWZESoa+yllDtCL46g3wF97Mr/lTkxh25z/RSAre3r5/5dJhrB4WeNaYwIU=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5n63-007jv5-L7 for sox-devel@lists.sourceforge.net; Wed, 12 Aug 2020 09:31:01 +0000 Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:8d8e::3]) by unicorn.mansr.com (Postfix) with ESMTPS id B242615360; Wed, 12 Aug 2020 10:30:44 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id A4F0721A6F2; Wed, 12 Aug 2020 10:30:44 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Eric Wong References: <20200812042504.GA22122@dcvr> Date: Wed, 12 Aug 2020 10:30:44 +0100 In-Reply-To: <20200812042504.GA22122@dcvr> (Eric Wong's message of "Wed, 12 Aug 2020 04:25:04 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1k5n63-007jv5-L7 Subject: Re: WAV reader cleanup X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Eric Wong writes: > M=E5ns Rullg=E5rd wrote: >> M=E5ns Rullg=E5rd writes: >> = >> > I have done a thorough overhaul of the WAV file reader, fixing several >> > open bugs as well as some I discovered while working on it. Now any >> > change of this magnitude is not without risk of breaking something that >> > used to work. I have tested it on a few thousand WAV files without >> > observing any unexpected changes. Still, I may have missed something. >> > >> > The new code is in the 'new-wave' branch in the git repo. Please try = it >> > out, especially if you have any weird WAV files lying around. >> = >> Nobody? > > I took a quick look at the new-wave branch and didn't notice > anything jump out at me. lsx_read_fields is nice :> > > I don't have any WAV files lying around; all my stored files are > FLAC for checksumming. .sox sometimes for temporary stuff, but > usually it's all via pipes. Thanks for checking it over. It's not easy reading, but hopefully the code is a bit cleaner now. -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel