WAV reader cleanup

WAV reader cleanup

[Måns Rullgård]

I have done a thorough overhaul of the WAV file reader, fixing several
open bugs as well as some I discovered while working on it.  Now any
change of this magnitude is not without risk of breaking something that
used to work.  I have tested it on a few thousand WAV files without
observing any unexpected changes.  Still, I may have missed something.

The new code is in the 'new-wave' branch in the git repo.  Please try it
out, especially if you have any weird WAV files lying around.

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

Re: WAV reader cleanup

[Måns Rullgård]

Måns Rullgård <mans@mansr.com> writes:

> I have done a thorough overhaul of the WAV file reader, fixing several
> open bugs as well as some I discovered while working on it.  Now any
> change of this magnitude is not without risk of breaking something that
> used to work.  I have tested it on a few thousand WAV files without
> observing any unexpected changes.  Still, I may have missed something.
>
> The new code is in the 'new-wave' branch in the git repo.  Please try it
> out, especially if you have any weird WAV files lying around.

Nobody?

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

Re: WAV reader cleanup

[Eric Wong]

Måns Rullgård <mans@mansr.com> wrote:
> Måns Rullgård <mans@mansr.com> writes:
> 
> > I have done a thorough overhaul of the WAV file reader, fixing several
> > open bugs as well as some I discovered while working on it.  Now any
> > change of this magnitude is not without risk of breaking something that
> > used to work.  I have tested it on a few thousand WAV files without
> > observing any unexpected changes.  Still, I may have missed something.
> >
> > The new code is in the 'new-wave' branch in the git repo.  Please try it
> > out, especially if you have any weird WAV files lying around.
> 
> Nobody?

I took a quick look at the new-wave branch and didn't notice
anything jump out at me.  lsx_read_fields is nice :>

I don't have any WAV files lying around; all my stored files are
FLAC for checksumming.  .sox sometimes for temporary stuff, but
usually it's all via pipes.


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

Re: WAV reader cleanup

[Måns Rullgård]

Eric Wong <normalperson@yhbt.net> writes:

> Måns Rullgård <mans@mansr.com> wrote:
>> Måns Rullgård <mans@mansr.com> writes:
>> 
>> > I have done a thorough overhaul of the WAV file reader, fixing several
>> > open bugs as well as some I discovered while working on it.  Now any
>> > change of this magnitude is not without risk of breaking something that
>> > used to work.  I have tested it on a few thousand WAV files without
>> > observing any unexpected changes.  Still, I may have missed something.
>> >
>> > The new code is in the 'new-wave' branch in the git repo.  Please try it
>> > out, especially if you have any weird WAV files lying around.
>> 
>> Nobody?
>
> I took a quick look at the new-wave branch and didn't notice
> anything jump out at me.  lsx_read_fields is nice :>
>
> I don't have any WAV files lying around; all my stored files are
> FLAC for checksumming.  .sox sometimes for temporary stuff, but
> usually it's all via pipes.

Thanks for checking it over.  It's not easy reading, but hopefully the
code is a bit cleaner now.

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel