sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: "Måns Rullgård" <mans@mansr.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: sox-devel@lists.sourceforge.net
Subject: Re: better sndio support in SoX
Date: Tue, 20 Sep 2016 21:06:15 +0100	[thread overview]
Message-ID: <yw1x4m5atjyg.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <20160920193945.GA6738@starla> (Eric Wong's message of "Tue, 20 Sep 2016 19:39:45 +0000")

Eric Wong <normalperson@yhbt.net> writes:

> Jan Stary <hans@stare.cz> wrote:
>> Hi Eric,
>> 
>> recently, Alex Ratchov (of OpenBSD's sndio) has added a diff
>> to src/sndio.c that enables a finer setting of the desired
>> parameters of the underlying audio (namely, bit width).
>> 
>> Currently, the diff (attached) exists as a patch to the OpenBSD
>> port of SoX (which I maintain). Would you please consider
>> incorporating this change into SoX directly?
>
> Hi Jan,
>
> Seems reasonable; but I have little experience with using sndio
> with Måns sox, much less the API.  Perhaps Måns has an opinion,
> too.

None of my changes should have any impact on this.

> Fwiw, it would be helpful if example files could be
> provided/generated showing where the improvement is.

I'm not familiar with sndio, but it looks like it changes how 24-bit
samples are passed, packed rather than padded to 32 bits.

The patch looks sane, and if OpenBSD is anyway building with this, it's
probably good to pick it up.

>> $OpenBSD$
>> --- src/sndio.c.orig	Mon Jan 30 04:01:44 2012
>> +++ src/sndio.c	Tue Feb  9 23:23:00 2016
>> @@ -113,8 +113,6 @@ static int startany(sox_format_t *ft, unsigned mode)
>>      else
>>        reqpar.rchan = ft->signal.channels;
>>    }
>> -  if (ft->signal.precision > 0)
>> -    reqpar.bits = ft->signal.precision;
>>    switch (ft->encoding.encoding) {
>>    case SOX_ENCODING_SIGN2:
>>      reqpar.sig = 1;
>> @@ -127,6 +125,12 @@ static int startany(sox_format_t *ft, unsigned mode)
>>    }
>>    if (ft->encoding.bits_per_sample > 0)
>>      reqpar.bits = ft->encoding.bits_per_sample;
>> +  else if (ft->signal.precision > 0)
>> +    reqpar.bits = ft->signal.precision;
>> +  else
>> +    reqpar.bits = SOX_DEFAULT_PRECISION;
>> +  reqpar.bps = (reqpar.bits + 7) / 8;
>> +  reqpar.msb = 1;
>>    if (ft->encoding.reverse_bytes != sox_option_default) {
>>      reqpar.le = SIO_LE_NATIVE;
>>      if (ft->encoding.reverse_bytes)

-- 
Måns Rullgård

------------------------------------------------------------------------------

  reply	other threads:[~2016-09-20 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 11:29 better sndio support in SoX Jan Stary
2016-09-20 19:39 ` Eric Wong
2016-09-20 20:06   ` Måns Rullgård [this message]
2016-09-20 21:36   ` Jan Stary
2016-09-20 22:24     ` Eric Wong
2016-09-21  5:45       ` Jan Stary
2016-09-21  6:58         ` Eric Wong
2016-09-21  7:19           ` Jan Stary
2016-09-21 11:42             ` Alexandre Ratchov
2016-09-21 11:19         ` Måns Rullgård
2016-09-21 11:42           ` Alexandre Ratchov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw1x4m5atjyg.fsf@unicorn.mansr.com \
    --to=sox-devel@lists.sourceforge.net \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).