From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8D1B01F66E for ; Tue, 11 Aug 2020 15:17:30 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5W1o-0007F9-6G; Tue, 11 Aug 2020 15:17:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5W1n-0007Ex-4Q for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 15:17:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=szd+Wg3KyVDppo2utpFrrswJZZF9+qeUflb87dyC0PQ=; b=ThCYKnkhbS/Y3xsmMAi6c870Ke LUk6mM6wjdtTZBAqTSj4w6wDl+XKLh94jdfGpsSuqW/8mcOg5pzgRC0Us9xQIAMlDlrjpbCQsGv0S MxaxGF9FryoiGxI08NT6JZBR1oL7uPHb6HjkVGcRelDmxHERFbRAcIWrSfantS0SEOUE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=szd+Wg3KyVDppo2utpFrrswJZZF9+qeUflb87dyC0PQ=; b=cMQEG+yrLQaMFanXtvQ8z041AS XaJZfnmleQ6GZ5R5yI8YFxilU/fvN2CZf/scFeprQPJsgczcBZ2zyevilaKIe2ozflkChIOkOQiSZ XALfTTQYL+w5nQ3OHpMTVxqyJJd9pfdGeUNYBza3CGLUCj5DtWb12qfMMtR1VB9WzzoU=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5W1l-0091F4-DA for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 15:17:27 +0000 Received: from raven.mansr.com (raven.mansr.com [81.2.72.235]) by unicorn.mansr.com (Postfix) with ESMTPS id 7FB8B15360; Tue, 11 Aug 2020 16:17:12 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 4485C21A6F2; Tue, 11 Aug 2020 16:17:12 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Jan Stary References: <20200810121707.29623-1-mans@mansr.com> <20200811133407.GA88171@www.stare.cz> <20200811144002.GC63033@www.stare.cz> Date: Tue, 11 Aug 2020 16:17:12 +0100 In-Reply-To: <20200811144002.GC63033@www.stare.cz> (Jan Stary's message of "Tue, 11 Aug 2020 16:40:03 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1k5W1l-0091F4-DA Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Jan Stary writes: > On Aug 11 14:58:20, mans@mansr.com wrote: >> > Current SoX git builds and runs fine on OpenBSD >> > (except the recent -Wl,--as-needed) using sndio, >> > if ./configure'd right. The OpenBSD port of SoX 14.4.2 >> > http://cvsweb.openbsd.org/ports/audio/sox/Makefile?rev=3D1.72 >> > explicitly builds --without-oss --without-sunaudio --with-sndio >> > >> > In fact, these options are necessary (that is to say, >> > the autodetection is broken); when ./configure'd without options, >> > it detects each of sndio, ossaudio and sunaudio, and fails with >> > >> > sox.c: In function 'adjust_volume': >> > sox.c:1337: error: 'audio_info_t' undeclared (first use in this functi= on) >> > sox.c:1337: error: (Each undeclared identifier is reported only once >> > sox.c:1337: error: for each function it appears in.) >> > sox.c:1337: error: expected ';' before 'audio_info' >> > sox.c:1338: error: 'AUDIO_GETINFO' undeclared (first use in this funct= ion) >> > sox.c:1338: error: 'audio_info' undeclared (first use in this function) >> > sox.c:1341: warning: implicit declaration of function 'AUDIO_INITINFO' >> > sox.c:1345: error: 'AUDIO_SETINFO' undeclared (first use in this funct= ion) >> > >> > (These are artifacts of sunaudio, right?) >> = >> That's what it looks like. Does OpenBSD have an audioio.h file for some >> other purpose? > > There is , see http://man.openbsd.org/audio > Apparently, this is the uniform audio HW abstraction > implemented by the individual audio card drivers: > > ./dev/pci/auacer.c:#include > ./dev/pci/auglx.c:#include > ./dev/pci/auich.c:#include > ./dev/pci/auixp.c:#include > ./dev/pci/autri.c:#include > ./dev/pci/auvia.c:#include > [...] OK, so we definitely need a more specific test here. It also seems[1] like in Solaris 8 that file was to sys/audio.h where it remains[2]. [1] https://docs.oracle.com/cd/E19455-01/816-3330/6m9kamh4f/index.html [2] https://docs.oracle.com/cd/E88353_01/html/E37851/audio-4i.html >> > A naive 'grep -Fr audio_info_t .' reveals that SoX ships with >> > >> > src/bit-rot/ >> > src/bit-rot/CoreAudio >> > src/bit-rot/CoreAudio/CoreAudio.h >> > src/bit-rot/mmreg.h >> > src/bit-rot/mmsystem.h >> > src/bit-rot/sndio.h >> > src/bit-rot/sys >> > src/bit-rot/sys/audioio.h >> > src/bit-rot/windows.h >> > >> > What are these for? >> = >> Probably to compile-test the related source files on other systems. > > I don't understand: what compile-test? > > Why do we have e.g. src/bit-rot/sndio.h? > If we are on a sndio system (such as OpenBSD), > there will be a sndio.h we can use; > on other systems, how would we use src/bit-rot/sndio.h? There's a commented-out line in the Makefile that adds -Ibit-rot to the compiler flags. I'm guessing someone used (or intended to use) this to compile e.g. sndio.c. It would obviously still fail to link. The purpose of this would (presumably) be to make sure those files are kept up to date if changes are made to the libsox internal interface. -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel