From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6130 216.105.38.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B0D0A1F461 for ; Tue, 9 Jul 2019 10:00:53 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hkmvS-0002fa-NQ; Tue, 09 Jul 2019 10:00:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hkmvR-0002fE-Ht for sox-devel@lists.sourceforge.net; Tue, 09 Jul 2019 10:00:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vQN93NSt8mBLahdikLqyPqZ/xze1q1aY7o4EhHb4h0A=; b=PgAMn6I0c7d1A3BcIKJXiVA3dL spdtM1ECJynZQeqnqm0GLyibhuEY8q2knAeB4/9EuMinzXVorReiZh2KI90Fqp7wVDUkrmkQKc3Pd XFy9+OmMzb03MNmkRANfb4cJaGdwR/85Go/W+Wip462Ymy+7hl8u2u6AhnqlXDCG5GAk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vQN93NSt8mBLahdikLqyPqZ/xze1q1aY7o4EhHb4h0A=; b=i3KVMoBoStRJ2FkH/8BDWtvsGA RAYWgxcuED8r8FMUUs5jUJIkdrISVJcowQ9ekA8T/Oiza01QHfnzeyTmubICS1C6qdEAd1BpL929a oC3DdGs4GdUNBlLraSESXP0Z1VAdcfMP8Kw57VASlm8ZcuPVCHS2c4CqR2/rkobFmspo=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hkmvQ-00CSfj-9C for sox-devel@lists.sourceforge.net; Tue, 09 Jul 2019 10:00:41 +0000 Received: by unicorn.mansr.com (Postfix, from userid 51770) id A28231539B; Tue, 9 Jul 2019 10:44:12 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: SoX-devel References: <2025529462.6370985.1562591692400.ref@mail.yahoo.com> <2025529462.6370985.1562591692400@mail.yahoo.com> Date: Tue, 09 Jul 2019 10:44:12 +0100 In-Reply-To: <2025529462.6370985.1562591692400@mail.yahoo.com> (Wolfgang Stoeggl via SoX-devel's message of "Mon, 8 Jul 2019 13:14:52 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1hkmvQ-00CSfj-9C Subject: Re: [Patch] Fix win32-glob.c resource leak hfindfile X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: sox-devel-bounces@lists.sourceforge.net Wolfgang Stoeggl via SoX-devel writes: > Hello, > please find attached a patch for src/win32-glob.c > > I have just realized, that the merge requests are not in use [1], so I am > posting the patch file here. > > Fix win32-glob.c resource leak hfindfile > > Open the HANDLE hfindfile later, after the checks of pattern, flags, > unused, pglob and length of file name. This avoids a possible return > from function glob() without FindClose(hfindfile). > > - Fixes the following Cppcheck errors: > =A0 [src/win32-glob.c:80] > =A0=A0=A0 (error) Resource leak: hfindfile [resourceLeak] > =A0 [src/win32-glob.c:88] > =A0=A0=A0 (error) Resource leak: hfindfile [resourceLeak] Thanks, added to master. -- = M=E5ns Rullg=E5rd _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel