From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: SourceForge.net Newsgroups: gmane.comp.audio.sox.devel Subject: [ sox-Feature Requests-2214694 ] Do not export lsx_ symbols in libsox Date: Fri, 08 Mar 2013 04:01:37 -0800 Message-ID: Reply-To: sox-devel@lists.sourceforge.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362744102 4441 80.91.229.3 (8 Mar 2013 12:01:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Mar 2013 12:01:42 +0000 (UTC) To: SourceForge.net Original-X-From: sox-devel-bounces@lists.sourceforge.net Fri Mar 08 13:02:05 2013 Return-path: Envelope-to: gcasd-sox-devel@m.gmane.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=beta; h=Message-Id:Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Reply-To:Subject:MIME-Version:Date:From:To; bh=GqcvydVgfOry4t6f5/yQNBQrJ+/W8v0uADx7aYL02Y8=; b=QOsIfkRbCX/ChfYH/bH8K/N5EPPWFA3WUm55dvqPwfiMhonPUGxHJ5S2NKqtLPp+wTJ/KRV6BinhIH3vNmA3wyUfZfdNBXeGJoy9uKdGNnsnNbYmw0O8fkVG2mk6xnRmPhDZJH6SoY8BNBzBPQ+QbEcNhUHrKpkZgeMW5SI6tLI=; Received-SPF: neutral (sog-mx-2.v43.ch3.sourceforge.com: 172.29.29.66 is neither permitted nor denied by domain of sourceforge.net) client-ip=172.29.29.66; envelope-from=noreply@sourceforge.net; helo=localhost; X-SourceForge-Tracker-unixname: sox X-SourceForge-Tracker-trackerid: 360706 X-SourceForge-Tracker-itemid: 2214694 X-SourceForge-Tracker-itemstatus: Open X-SourceForge-Tracker-itemassignee: nobody X-SourceForge-Tracker-itemupdate-reason: Comment added X-SourceForge-Tracker-itemupdate-username: uklauer Content-Disposition: inline X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: sox-devel-bounces@lists.sourceforge.net Xref: news.gmane.org gmane.comp.audio.sox.devel:268 Archived-At: Received: from lists.sourceforge.net ([216.34.181.88]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UDvzu-0000X9-4e for gcasd-sox-devel@m.gmane.org; Fri, 08 Mar 2013 13:02:02 +0100 Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UDvzX-0001pZ-5G; Fri, 08 Mar 2013 12:01:39 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UDvzV-0001pR-MJ for sox-devel@lists.sourceforge.net; Fri, 08 Mar 2013 12:01:37 +0000 Received: from sfs-web-6.v29.ch3.sourceforge.com ([172.29.29.66] helo=localhost) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UDvzV-0005Jo-Ki; Fri, 08 Mar 2013 12:01:37 +0000 Feature Requests item #2214694, was opened at 2008-11-01 14:12 Message generated for change (Comment added) made by uklauer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360706&aid=2214694&group_id=10706 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Chris Bagwell (cbagwell) Assigned to: Nobody/Anonymous (nobody) Summary: Do not export lsx_ symbols in libsox Initial Comment: If you look at the public symbols in libsox, you'll see a lot of symbols that we do not advertise as part of the SoX API. They have all been prefixed with lsx_ to help distinguish them. It would be nice to not export those as public symbols. Most obvious option is to make use of -retain-symbols-file where it is supported. I think I've also seen attempts to do this at compile time by png.h (not sure if it works or worth the trouble it looks like it causes). ---------------------------------------------------------------------- >Comment By: Ulrich Klauer (uklauer) Date: 2013-03-08 04:01 Message: This can, in principle, be easily done via libtool's -export-symbols-regex option ("-export-symbols-regex '^sox_'"). However, SoX-the-application uses several internal functions (see "nm -Du `which sox` | grep lsx_"), and the modules built via --with-whatever=dyn some more. Therefore, the regex to use is more like: "^(sox_.*|lsx_(check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|fail_errno|filelength|find_(enum_(text|value)|file_extension)|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|realloc|rewind|seeki|sigfigs3p?|strcasecmp|tell |unreadb|write(b|_b_buf|buf|s)))$" Still, this hides about 90% of the private symbols, so I think I will actually add this, as a step in the right direction. To deal with the rest, we'd need to create a self-contained helper library that can be linked (statically) into the modules, and into SoX-the-application. But it is probably difficult to make it self-contained, as those functions in turn call more internal functions, etc. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360706&aid=2214694&group_id=10706 ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev