sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
* man pages - fix
@ 2017-11-18 22:31 Jaromír Mikeš
  2017-11-18 23:12 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Jaromír Mikeš @ 2017-11-18 22:31 UTC (permalink / raw)
  To: sox-devel, Måns Rullgård, Eric Wong


[-- Attachment #1.1: Type: text/plain, Size: 149 bytes --]

Hi,

we found little problem in sox man pages please consider use attached patch.
The warning said "table wider than line width"

best regards

mira

[-- Attachment #1.2: Type: text/html, Size: 644 bytes --]

[-- Attachment #2: 0011-lintian-man-sox.patch --]
[-- Type: text/x-patch, Size: 562 bytes --]

Description: Fix - W: sox: manpage-has-errors-from-man usr/share/man/man1/sox.1.gz  file `<standard input>'
Author: gabor.karsay@gmx.at
Jaromír Mikeš <mira.mikes@seznam.cz>
Forwarded: sox-devel@lists.sourceforge.net

diff --git a/sox.1 b/sox.1
index 2c4ca47..4241862 100644
--- a/sox.1
+++ b/sox.1
@@ -2699,7 +2699,7 @@ as detailed in the following table:
 .ne 6
 .TS
 center;
-lB lw52.
+lB lw51.
 \-M/\-I/\-L	Phase response = minimum/intermediate/linear
 \-s	Steep filter (band-width = 99%)
 \-a	Allow aliasing/imaging above the pass-band


[-- Attachment #3: Type: text/plain, Size: 202 bytes --]

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

[-- Attachment #4: Type: text/plain, Size: 158 bytes --]

_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: man pages - fix
  2017-11-18 22:31 man pages - fix Jaromír Mikeš
@ 2017-11-18 23:12 ` Eric Wong
  2017-11-19  8:14   ` Jaromír Mikeš
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2017-11-18 23:12 UTC (permalink / raw)
  To: Jaromír Mikeš; +Cc: Måns Rullgård, sox-devel

Jaromír Mikeš <mira.mikes@gmail.com> wrote:
> Hi,
> 
> we found little problem in sox man pages please consider use attached patch.
> The warning said "table wider than line width"

Sure, no objections to the actual patch, here.


I'm curious how you generate the patch, since the headers seem
machine-generated, but it's clearly not from "git format-patch"

Personally, I don't mind patch attachments at all (though some
people do and prefer inline patches)

However, "git format-patch" allows us to use "git am" to apply the
patch while preserve authorship and commit message information,
making life easier for folks applying the patches :)

> Description: Fix - W: sox: manpage-has-errors-from-man usr/share/man/man1/sox.1.gz  file `<standard input>'
> Author: gabor.karsay@gmx.at
> Jaromír Mikeš <mira.mikes@seznam.cz>
> Forwarded: sox-devel@lists.sourceforge.net

Here's the proposed patch I will apply, with gabor.karsay@gmx.at
as the author, and crediting you in the Reported-By:

https://80x24.org/20171118230550.24596-1-e@80x24.org/raw


Anyways, format-patch/am is the standard git workflow
for git.git and Linux kernel development.  The attachment thing
is/was frowned upon, but Torvalds does himself it on LKML *shrug*

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: man pages - fix
  2017-11-18 23:12 ` Eric Wong
@ 2017-11-19  8:14   ` Jaromír Mikeš
  0 siblings, 0 replies; 3+ messages in thread
From: Jaromír Mikeš @ 2017-11-19  8:14 UTC (permalink / raw)
  To: Eric Wong; +Cc: Måns Rullgård, sox-devel


[-- Attachment #1.1: Type: text/plain, Size: 1172 bytes --]

2017-11-19 0:12 GMT+01:00 Eric Wong <normalperson@yhbt.net>:

> Jaromír Mikeš <mira.mikes@gmail.com> wrote:
> > Hi,
> >
> > we found little problem in sox man pages please consider use attached
> patch.
> > The warning said "table wider than line width"
>
> Sure, no objections to the actual patch, here.
>
>
> I'm curious how you generate the patch, since the headers seem
> machine-generated, but it's clearly not from "git format-patch"
>

​I got  patch from gabor.karsay@gmx.at as attachment ( without a header )
I added a header dep-3 header (manually)

http://dep.debian.net/deps/dep3/

maybe if I would use this result would be better?
$quilt header --dep3 -e


>
> Personally, I don't mind patch attachments at all (though some
> people do and prefer inline patches)
>
> However, "git format-patch" allows us to use "git am" to apply the
> patch while preserve authorship and commit message information,
> making life easier for folks applying the patches :)
>

​I will investigate git format-patch ​to understand how to make thing
easier for upstream.
Nevertheless DEP-3 is debian patch header

best regards

mira

[-- Attachment #1.2: Type: text/html, Size: 2409 bytes --]

[-- Attachment #2: Type: text/plain, Size: 202 bytes --]

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

[-- Attachment #3: Type: text/plain, Size: 158 bytes --]

_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-19  8:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-18 22:31 man pages - fix Jaromír Mikeš
2017-11-18 23:12 ` Eric Wong
2017-11-19  8:14   ` Jaromír Mikeš

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).