From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6130 216.105.38.0/24 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EC1DA1F463 for ; Mon, 16 Dec 2019 18:14:36 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1igut3-0000mC-Ag; Mon, 16 Dec 2019 18:14:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1igut2-0000ly-2f for sox-devel@lists.sourceforge.net; Mon, 16 Dec 2019 18:14:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6KFU8shWU6gzja0mD+RHOiT8GrUCGmBHWKoFsewn/EE=; b=mnIfM7kXHTgi8ujhQPTsp7fw5B 0c8u/1qVngSrfZ97igZyHvXmCv+zNnC8E5kl63sdU87VpojW473veZYh3oMKKSqihcNVWiVggGj0V zycQzreHymigN7Sa9gwQJ1jSSmqvcSd34Q6Bt4feeqLTq7rJbSoa9IFzle+ergQy3uGo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6KFU8shWU6gzja0mD+RHOiT8GrUCGmBHWKoFsewn/EE=; b=Z21VmY5WQkh3E4EU/W2KhvTDcg HRxoG2RGMCufQFRr9qWpRiqQNBVRJxWMT54ahwzyllnmxqJfggBqobRn/2JQc9+iqmYGKEoIOI+1+ 6q46XNDDJUce6H/MXtVa196tAB4ITnAbhfLqZFIQjAAHlzUSdtcvTEyr83Y/aYq9ZvE0=; Received: from mail-oi1-f178.google.com ([209.85.167.178]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1igusz-0070Rp-Vz for sox-devel@lists.sourceforge.net; Mon, 16 Dec 2019 18:14:28 +0000 Received: by mail-oi1-f178.google.com with SMTP id x195so4063911oix.4 for ; Mon, 16 Dec 2019 10:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6KFU8shWU6gzja0mD+RHOiT8GrUCGmBHWKoFsewn/EE=; b=DsBPYUg/GfQ/ERmcK9pdeYdAHBopX5wP7Zx+PYG16H6pYvtLQQ5iTt4bYa9nb60cup Ot1NawW1FdzunrpEbLAez80yfBKRY/Td5iihcjJ/vHBABNr/VLMHKq9pE1DXAx3KifSH FNCdzAOeHuB3Tngoi0h3kQlSHX6lRhgWoe/MZv+5a8KyQFUQQ2q3GJURWId/WMM2ilBq UiTPdu+d+9HsZTPyUt+jkQ8LG+QKuIce1IV1/nPigO7LvW+fsZXKybqtwEHAUAg1KiZs Zx95PGnUtiLXfhVDcnUc3SWa6ndE+Kjj7H1hbOrC44xYN0MPQImsTDqEwhNsb2gAGyEf w8PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6KFU8shWU6gzja0mD+RHOiT8GrUCGmBHWKoFsewn/EE=; b=tL/iVW3oa2b00ARv4k2LIU9h0M6mWF+ZaPm8m5sisuKeOfqucdefGwguFry6hDC6L3 wXkpuuYuHjCK6cHp/ugDhiAOyxPjMsoZsNCEv9O9g69n1h3eNLJl6CW65MoJL+dIuAVQ bEkKX23Aj+aDIvydm5I2JqwqWSlXotpX/LqSL/6nZGln0zBkaN0RWTZDauRi+otvj+RK jwYx61Nmd9XopG985UMu/Xp/RXTrW05A6isCmX6N7eocMap2wZ8/bbIyOAoPL8I2sx5a sP49i4bxtzbAl0dpu4HlIEvPhFBKt3w7srhpUqQb+1d6zjRWBMlT/0JqYh7AS3WnHwCA ihvA== X-Gm-Message-State: APjAAAWX96125P6YuzyL0RjG4d4MbbTVlPDrzFoIt8wHctbZhg3lhUDf Ounb8rkak9xb+2wy7zsbrzdlkY7UZlrzTjznHHrRk+oO X-Google-Smtp-Source: APXvYqwObMu7ZUa3KB+E2qZ469w3WX5qSOmcfIw0YUAKySU/LXa1r+msDavep+3Rpy9/SzT542rt3UNse55bghUjw7w= X-Received: by 2002:aca:c256:: with SMTP id s83mr212721oif.57.1576520059774; Mon, 16 Dec 2019 10:14:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Seth Troisi Date: Mon, 16 Dec 2019 10:13:53 -0800 Message-ID: To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= X-Headers-End: 1igusz-0070Rp-Vz Subject: Re: [Patch] Change to exit(0) for --help-format X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: multipart/mixed; boundary="===============4186214883919547077==" Errors-To: sox-devel-bounces@lists.sourceforge.net --===============4186214883919547077== Content-Type: multipart/alternative; boundary="00000000000024eb4f0599d62ea0" --00000000000024eb4f0599d62ea0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I'd like to know if the mp3 format is supported from python. it's much easier to check an exit code than to grep over stdout for a strin= g On Mon, Dec 16, 2019 at 3:51 AM M=C3=A5ns Rullg=C3=A5rd wr= ote: > Seth Troisi writes: > > > exit(0) if --help-format is found (or all). > > continue to exit(1) if fmt is not found. > > > > This is my first patch, let me know what I can do to make this happen. > > Could you explain why you want to make this change? What problem does > it solve? > > > From 61fafa760a32f9ec1b096ff92ed4f39c1f9d95e7 Mon Sep 17 00:00:00 2001 > > From: Seth Troisi > > Date: Thu, 12 Dec 2019 17:16:44 -0800 > > Subject: [PATCH] Change exit to 0 for --help-format if fmt is fou= nd > > > > --- > > src/sox.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/sox.c b/src/sox.c > > index 15f0df67..b5a827fc 100644 > > --- a/src/sox.c > > +++ b/src/sox.c > > @@ -2133,6 +2133,7 @@ static void usage_format(char const * name) > > if (!(f =3D sox_find_format(name, sox_false))) { > > printf("Cannot find a format called `%s'.\n", name); > > display_supported_formats(); > > + exit(1); > > } > > else usage_format1(f); > > } > > @@ -2143,7 +2144,7 @@ static void usage_format(char const * name) > > usage_format1(f); > > } > > } > > - exit(1); > > + exit(0); > > } > > > > static void read_comment_file(sox_comments_t * comments, char const * > const filename) > > -- > > 2.24.1.735.g03f4e72817-goog > > > > > > _______________________________________________ > > SoX-devel mailing list > > SoX-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/sox-devel > > > > -- > M=C3=A5ns Rullg=C3=A5rd > --00000000000024eb4f0599d62ea0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'd like to know if the mp3 format is supported from p= ython.
it's much easier to check an exit code than to grep over std= out for a string





On Mon, Dec 16, 2019 at 3:51 AM M=C3=A5ns Rul= lg=C3=A5rd <mans@mansr.com> wro= te:
Seth Troisi = <braintwo@gmail.= com> writes:

> exit(0) if --help-format <fmt> is found (or all).
> continue to exit(1) if fmt is not found.
>
> This is my first patch, let me know what I can do to make this happen.=

Could you explain why you want to make this change?=C2=A0 What problem does=
it solve?

> From 61fafa760a32f9ec1b096ff92ed4f39c1f9d95e7 Mon Sep 17 00:00:00 2001=
> From: Seth Troisi <sethtroisi@google.com>
> Date: Thu, 12 Dec 2019 17:16:44 -0800
> Subject: [PATCH] Change exit to 0 for --help-format <fmt> if fmt= is found
>
> ---
>=C2=A0 src/sox.c | 3 ++-
>=C2=A0 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/sox.c b/src/sox.c
> index 15f0df67..b5a827fc 100644
> --- a/src/sox.c
> +++ b/src/sox.c
> @@ -2133,6 +2133,7 @@ static void usage_format(char const * name)
>=C2=A0 =C2=A0 =C2=A0 if (!(f =3D sox_find_format(name, sox_false))) { >=C2=A0 =C2=A0 =C2=A0 =C2=A0 printf("Cannot find a format called `%= s'.\n", name);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 display_supported_formats();
> +=C2=A0 =C2=A0 =C2=A0 exit(1);
>=C2=A0 =C2=A0 =C2=A0 }
>=C2=A0 =C2=A0 =C2=A0 else usage_format1(f);
>=C2=A0 =C2=A0 }
> @@ -2143,7 +2144,7 @@ static void usage_format(char const * name)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 usage_format1(f);
>=C2=A0 =C2=A0 =C2=A0 }
>=C2=A0 =C2=A0 }
> -=C2=A0 exit(1);
> +=C2=A0 exit(0);
>=C2=A0 }
>=C2=A0
>=C2=A0 static void read_comment_file(sox_comments_t * comments, char co= nst * const filename)
> --
> 2.24.1.735.g03f4e72817-goog
>
>
> _______________________________________________
> SoX-devel mailing list
> S= oX-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listi= nfo/sox-devel
>

--
M=C3=A5ns Rullg=C3=A5rd
--00000000000024eb4f0599d62ea0-- --===============4186214883919547077== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4186214883919547077== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel --===============4186214883919547077==--