Re: [Patch] Change to exit(0) for --help-format

[Seth Troisi <braintwo@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1849 bytes --]

I'd like to know if the mp3 format is supported from python.
it's much easier to check an exit code than to grep over stdout for a string





On Mon, Dec 16, 2019 at 3:51 AM Måns Rullgård <mans@mansr.com> wrote:

> Seth Troisi <braintwo@gmail.com> writes:
>
> > exit(0) if --help-format <fmt> is found (or all).
> > continue to exit(1) if fmt is not found.
> >
> > This is my first patch, let me know what I can do to make this happen.
>
> Could you explain why you want to make this change?  What problem does
> it solve?
>
> > From 61fafa760a32f9ec1b096ff92ed4f39c1f9d95e7 Mon Sep 17 00:00:00 2001
> > From: Seth Troisi <sethtroisi@google.com>
> > Date: Thu, 12 Dec 2019 17:16:44 -0800
> > Subject: [PATCH] Change exit to 0 for --help-format <fmt> if fmt is found
> >
> > ---
> >  src/sox.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/sox.c b/src/sox.c
> > index 15f0df67..b5a827fc 100644
> > --- a/src/sox.c
> > +++ b/src/sox.c
> > @@ -2133,6 +2133,7 @@ static void usage_format(char const * name)
> >      if (!(f = sox_find_format(name, sox_false))) {
> >        printf("Cannot find a format called `%s'.\n", name);
> >        display_supported_formats();
> > +      exit(1);
> >      }
> >      else usage_format1(f);
> >    }
> > @@ -2143,7 +2144,7 @@ static void usage_format(char const * name)
> >          usage_format1(f);
> >      }
> >    }
> > -  exit(1);
> > +  exit(0);
> >  }
> >
> >  static void read_comment_file(sox_comments_t * comments, char const *
> const filename)
> > --
> > 2.24.1.735.g03f4e72817-goog
> >
> >
> > _______________________________________________
> > SoX-devel mailing list
> > SoX-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/sox-devel
> >
>
> --
> Måns Rullgård
>

[-- Attachment #1.2: Type: text/html, Size: 2809 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



[-- Attachment #3: Type: text/plain, Size: 158 bytes --]

_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel