sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: Seth Troisi <braintwo@gmail.com>
To: sox-devel@lists.sourceforge.net
Subject: [Patch] Change to exit(0) for --help-format
Date: Thu, 12 Dec 2019 17:21:58 -0800	[thread overview]
Message-ID: <CAEvcHoBh3aH==o9k5ChZOor1D5a1CQXOaC5tU962yeoLKVKuOw@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 176 bytes --]

exit(0) if --help-format <fmt> is found (or all).
continue to exit(1) if fmt is not found.

This is my first patch, let me know what I can do to make this happen.
Thanks,
Seth

[-- Attachment #1.2: Type: text/html, Size: 257 bytes --]

[-- Attachment #2: 0001-Change-exit-to-0-for-help-format-fmt-if-fmt-is-found.patch --]
[-- Type: text/x-patch, Size: 921 bytes --]

From 61fafa760a32f9ec1b096ff92ed4f39c1f9d95e7 Mon Sep 17 00:00:00 2001
From: Seth Troisi <sethtroisi@google.com>
Date: Thu, 12 Dec 2019 17:16:44 -0800
Subject: [PATCH] Change exit to 0 for --help-format <fmt> if fmt is found

---
 src/sox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/sox.c b/src/sox.c
index 15f0df67..b5a827fc 100644
--- a/src/sox.c
+++ b/src/sox.c
@@ -2133,6 +2133,7 @@ static void usage_format(char const * name)
     if (!(f = sox_find_format(name, sox_false))) {
       printf("Cannot find a format called `%s'.\n", name);
       display_supported_formats();
+      exit(1);
     }
     else usage_format1(f);
   }
@@ -2143,7 +2144,7 @@ static void usage_format(char const * name)
         usage_format1(f);
     }
   }
-  exit(1);
+  exit(0);
 }
 
 static void read_comment_file(sox_comments_t * comments, char const * const filename)
-- 
2.24.1.735.g03f4e72817-goog


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



[-- Attachment #4: Type: text/plain, Size: 158 bytes --]

_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

             reply	other threads:[~2019-12-13  1:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13  1:21 Seth Troisi [this message]
2019-12-16 11:51 ` [Patch] Change to exit(0) for --help-format Måns Rullgård
2019-12-16 18:13   ` Seth Troisi
2019-12-17 12:01     ` Måns Rullgård
2019-12-17 18:43       ` Seth Troisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEvcHoBh3aH==o9k5ChZOor1D5a1CQXOaC5tU962yeoLKVKuOw@mail.gmail.com' \
    --to=sox-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).