From: Sonny Ray <sonnyray@gmail.com>
To: sox-devel@lists.sourceforge.net
Cc: normalperson@yhbt.net
Subject: Re: [PATCH 6/8] adpcm: fix stack overflow with >4 channels (CVE-2017-15372)
Date: Sat, 28 Apr 2018 11:21:31 +0000 [thread overview]
Message-ID: <CACVDyvHjkefv+zt=SxxZLsWYzOXDCspQG732zNh-5sutMyR27w@mail.gmail.com> (raw)
In-Reply-To: <yw1xpo2jd2is.fsf@mansr.com>
[-- Attachment #1.1: Type: text/plain, Size: 1277 bytes --]
I'm using sox for a scalable multitrack recording use case. If we're going
to put a global cap, can it be something absurd to human eyes, like 256
channels or something? Or will that not resolve the bug?
On Sat, Apr 28, 2018 at 6:55 AM Måns Rullgård <mans@mansr.com> wrote:
> Eric Wong <normalperson@yhbt.net> writes:
>
> > Mans Rullgard <mans@mansr.com> wrote:
> >> +extern void *lsx_ms_adpcm_alloc(unsigned chans)
> >> +{
> >> + return lsx_malloc(chans * sizeof(MsState_t));
> >
> > Initially I thought this might overflow, but it appears channels
> > is capped to UINT16_MAX by the previous patch.
> >
> > On a side note, lsx_valloc could probably be updated to do
> > overflow checking and we could use it here to make future
> > auditing/review easier.
>
> We should probably also put a global cap on number of channels.
>
> --
> Måns Rullgård
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> SoX-devel mailing list
> SoX-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sox-devel
>
[-- Attachment #1.2: Type: text/html, Size: 1982 bytes --]
[-- Attachment #2: Type: text/plain, Size: 202 bytes --]
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
[-- Attachment #3: Type: text/plain, Size: 158 bytes --]
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
next prev parent reply other threads:[~2018-04-28 11:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 13:15 [PATCH 0/8] CVE fixes Mans Rullgard
2018-04-26 13:15 ` [PATCH 1/8] wav: fix crash if channel count is zero (CVE-2017-11332) Mans Rullgard
2018-04-26 13:15 ` [PATCH 2/8] hcom: fix crash on input with corrupt dictionary (CVE-2017-11358) Mans Rullgard
2018-04-26 13:15 ` [PATCH 3/8] wav: fix crash writing header when channel count >64k (CVE-2017-11359) Mans Rullgard
2018-04-26 13:15 ` [PATCH 4/8] wav: ima_adpcm: fix buffer overflow on corrupt input (CVE-2017-15370) Mans Rullgard
2018-04-26 13:15 ` [PATCH 5/8] flac: fix crash on corrupt metadata (CVE-2017-15371) Mans Rullgard
2018-04-26 13:15 ` [PATCH 6/8] adpcm: fix stack overflow with >4 channels (CVE-2017-15372) Mans Rullgard
2018-04-28 0:34 ` Eric Wong
2018-04-28 10:54 ` Måns Rullgård
2018-04-28 11:21 ` Sonny Ray [this message]
2018-04-28 12:50 ` Måns Rullgård
2018-04-26 13:15 ` [PATCH 7/8] aiff: fix crash on empty comment chunk (CVE-2017-15642) Mans Rullgard
2018-04-26 13:15 ` [PATCH 8/8] xa: validate channel count (CVE-2017-18189) Mans Rullgard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.sourceforge.net/lists/listinfo/sox-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVDyvHjkefv+zt=SxxZLsWYzOXDCspQG732zNh-5sutMyR27w@mail.gmail.com' \
--to=sox-devel@lists.sourceforge.net \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).