sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
* commit 77360f7193a2 regression w/ `lame --id3v2-only`
@ 2022-06-22  0:36 Eric Wong
  2023-02-18  9:02 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2022-06-22  0:36 UTC (permalink / raw)
  To: sox-devel

commit 77360f7193a2ba2e (mp3: fix duration calculation, 2019-12-16)
appears incompatible with MP3s made using "lame --id3v2-only".
sox ends up thinking the length is too short compared to the
actual MP3 length.

Reverting that commit fixes the issue.  I haven't had a chance
to look further into it, being mathematically challenged :x

I used a 11:23.00 source FLAC file (44.1 kHz, 16-bit, 2ch)
and fed it to "lame --id3v2-only /path/to.flac"

The resulting /path/to.mp3 is only 15.49 seconds long when
fed to soxi (but correctly 11:23.05 according to "ffprobe -i").
"play" stops after 15.49s, and "sox /path/to.mp3 -n stats"
only shows 15.488 seconds.  The 15.49s matches (to my ears)
the first 15.49s of the 11:23.00 track.

I can provide sample FLAC and mp3 files privately; but I suspect
they're not needed as I've reproduced it with a few other
CDDA-sourced FLAC files.

I'm using lame 3.100 as distributed w/ Debian buster (3.100-b+b1).
Omitting --id3v2-only from the lame invocation avoids this sox
regression.

Thanks.


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: commit 77360f7193a2 regression w/ `lame --id3v2-only`
  2022-06-22  0:36 commit 77360f7193a2 regression w/ `lame --id3v2-only` Eric Wong
@ 2023-02-18  9:02 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2023-02-18  9:02 UTC (permalink / raw)
  To: sox-devel

ping?


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-18  9:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-22  0:36 commit 77360f7193a2 regression w/ `lame --id3v2-only` Eric Wong
2023-02-18  9:02 ` Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).