From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6130 216.105.38.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3E8121F4D7 for ; Wed, 22 Jun 2022 00:37:08 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sourceforge.net header.i=@sourceforge.net header.b="aoFha7y2"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sf.net header.i=@sf.net header.b="DNYGZE+t"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yhbt.net header.i=@yhbt.net header.b="fP3RaIMT"; dkim-atps=neutral Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1o3oMc-0002Zw-U4; Wed, 22 Jun 2022 00:36:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o3oMc-0002ZX-3d for sox-devel@lists.sourceforge.net; Wed, 22 Jun 2022 00:36:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:Subject:To: From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9uZW1/V84+T3hHthXvtq8EGNqE4UbLFpu0/ZLhEzvg8=; b=aoFha7y2JdhzFP+pVCmxqcY+Bq i4x0pU/WbrFthTHPEP3JGLhYDe9dOjmkn4bR47Xab5yHKK73WyPChiI4oBpfCu0w0mcZ7UuG9W20i JiLvIAU609wFfn8h//2o2mABuqDnL6AZ90PX7+7BdtVPh6Plq5lwG1ofBZQDJf4SWizU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date:Sender:Reply-To :Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=9uZW1/V84+T3hHthXvtq8EGNqE4UbLFpu0/ZLhEzvg8=; b=D NYGZE+tYt7d+YOKXawsr4p+IsZ7Myj/UlvJ2as6XXYSzUtsj+QaXR4IHF7P/ouhLSfZXsuhHWIXJ7 Jzl3s5fJahw8TJHyy7lqah8c47S+fhEDjA9TscLT0mib79KTVQwrGSdo9o8lRNHZbc8iC86WUHGdk +rTyc3QY6wWFdElE=; Received: from dcvr.yhbt.net ([64.71.152.64]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1o3oMX-0001ZL-GJ for sox-devel@lists.sourceforge.net; Wed, 22 Jun 2022 00:36:56 +0000 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id DC0C71F4D7; Wed, 22 Jun 2022 00:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yhbt.net; s=selector1; t=1655858200; bh=jHq18y8h+TM0lqiiUURmKShJIznJH5DLf2r1Rb7kk3E=; h=Date:From:To:Subject:From; b=fP3RaIMTjuu8hZ4TntCsAIOddn7OIuE7joERwLY5aDziQZU69f/5Q3MOEkceUxwt6 Ph+tJTBwMSjzsR2lVYatbYXHiHmD8ufo1+SA6WeA8ysZn2jALV19RkGrULU1XLp4Qm E0HRraKupaBXAcvDDuXjrwFS5Qo2RsnuraUDT49A= Date: Wed, 22 Jun 2022 00:36:40 +0000 From: Eric Wong To: sox-devel@lists.sourceforge.net Message-ID: <20220622003640.GA5309@dcvr> MIME-Version: 1.0 Content-Disposition: inline X-Headers-End: 1o3oMX-0001ZL-GJ Subject: commit 77360f7193a2 regression w/ `lame --id3v2-only` X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net commit 77360f7193a2ba2e (mp3: fix duration calculation, 2019-12-16) appears incompatible with MP3s made using "lame --id3v2-only". sox ends up thinking the length is too short compared to the actual MP3 length. Reverting that commit fixes the issue. I haven't had a chance to look further into it, being mathematically challenged :x I used a 11:23.00 source FLAC file (44.1 kHz, 16-bit, 2ch) and fed it to "lame --id3v2-only /path/to.flac" The resulting /path/to.mp3 is only 15.49 seconds long when fed to soxi (but correctly 11:23.05 according to "ffprobe -i"). "play" stops after 15.49s, and "sox /path/to.mp3 -n stats" only shows 15.488 seconds. The 15.49s matches (to my ears) the first 15.49s of the 11:23.00 track. I can provide sample FLAC and mp3 files privately; but I suspect they're not needed as I've reproduced it with a few other CDDA-sourced FLAC files. I'm using lame 3.100 as distributed w/ Debian buster (3.100-b+b1). Omitting --id3v2-only from the lame invocation avoids this sox regression. Thanks. _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel