sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: sox-devel@lists.sourceforge.net
Subject: commit 77360f7193a2 regression w/ `lame --id3v2-only`
Date: Wed, 22 Jun 2022 00:36:40 +0000	[thread overview]
Message-ID: <20220622003640.GA5309@dcvr> (raw)

commit 77360f7193a2ba2e (mp3: fix duration calculation, 2019-12-16)
appears incompatible with MP3s made using "lame --id3v2-only".
sox ends up thinking the length is too short compared to the
actual MP3 length.

Reverting that commit fixes the issue.  I haven't had a chance
to look further into it, being mathematically challenged :x

I used a 11:23.00 source FLAC file (44.1 kHz, 16-bit, 2ch)
and fed it to "lame --id3v2-only /path/to.flac"

The resulting /path/to.mp3 is only 15.49 seconds long when
fed to soxi (but correctly 11:23.05 according to "ffprobe -i").
"play" stops after 15.49s, and "sox /path/to.mp3 -n stats"
only shows 15.488 seconds.  The 15.49s matches (to my ears)
the first 15.49s of the 11:23.00 track.

I can provide sample FLAC and mp3 files privately; but I suspect
they're not needed as I've reproduced it with a few other
CDDA-sourced FLAC files.

I'm using lame 3.100 as distributed w/ Debian buster (3.100-b+b1).
Omitting --id3v2-only from the lame invocation avoids this sox
regression.

Thanks.


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

             reply	other threads:[~2022-06-22  0:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  0:36 Eric Wong [this message]
2023-02-18  9:02 ` commit 77360f7193a2 regression w/ `lame --id3v2-only` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220622003640.GA5309@dcvr \
    --to=sox-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).