From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9FAF31F66E for ; Sun, 6 Sep 2020 11:59:13 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kEtKA-0002dY-RZ; Sun, 06 Sep 2020 11:59:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEtK9-0002dP-4w for sox-devel@lists.sourceforge.net; Sun, 06 Sep 2020 11:59:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Cc:From:Subject:To:Message-Id:Date: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aeAG7jiUfmIWdfgPjI0Na02YWc/CbJUo0nnrAnQLUwc=; b=UPwWXr2oPlkDFv45iGOEBxzY5P Yi4EmIDlmOkP9Em7eOht8Yt/qF+zzhTtNUowqFkfqc0j0D0Q3mHUcYOnw3l87uH2RDHQUSUSyPMlK KP719YBMRYqriH/cConDtjljfqKUVG1ZxLuUo7BCmIXA2sdheJ/DX6Tk2HkKBaWakkrM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Cc:From:Subject:To:Message-Id:Date:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aeAG7jiUfmIWdfgPjI0Na02YWc/CbJUo0nnrAnQLUwc=; b=NLFwF5BfFnkOYrCaiSEtAJXkS8 bFzdA840Xs2Ss2HSXReve3FEZKW2rG1MXGFWAlyix8o+AtPxaTZW2KNsFQEEf8hSqIrGgClesyYxr OFDVbyntP6TNZJNmnNLdnfRiUaRU5rLurC53OWQHkuDVXk07aeezARXU7TIXdwbSA4PI=; Received: from gw1.zacglen.com ([202.153.210.28] helo=mail.zacglen.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kEtK3-00EoXO-AB for sox-devel@lists.sourceforge.net; Sun, 06 Sep 2020 11:59:09 +0000 Received: (from local) by mail.zacglen.com (8.14.3/8.14.3) id 086Bwusr008005; Sun, 6 Sep 2020 21:58:56 +1000 Date: Sun, 6 Sep 2020 21:58:56 +1000 Message-Id: <202009061158.086Bwusr008005.mail.zacglen.com@localhost> To: mans@mansr.com From: fbk-qriry@zacglen.net In-Reply-To: X-Headers-End: 1kEtK3-00EoXO-AB Subject: Re: silence additional patch X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net > >> Further to my previous "silence" patch I have discovered >> that there is another error involving the rms calculations. >> >> Initially, and after a reset, the rms sample window is empty >> yet the rms calculation always uses the window size as >> the calculation denominator. This will make the rms >> value appear artificially low to start with. Instead, an >> actual count of samples should be used. >> >> Incidentally, I think that the hard-coded 1/50 for selection >> of a window size should also be parametized. Sometimes a size using >> 1/20 (100 milliseconds when stereo) can be more appropriate than the >> very small 40 millisecond hard-coded sample window size. >> >> The following is the updated patch: > >I'm certainly not going to take a patch with several unrelated changes >as is, nor am I going to do the work unravelling what's what. > I might also point out that the two issues I have rasied apply to the one same file, namely silence.c. Since patches must be applied in the correct order, and since you appear to unconditionally and irrationally rejected my first patch then I cannot possibly issue a patch that depends on the prior patch. Therefore it makes a lot of sense to submit an cumulative patch. :JW _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel