sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: fbk-qriry@zacglen.net
To: mans@mansr.com
Cc: sox-devel@lists.sourceforge.net
Subject: Re: silence additional patch
Date: Sun, 6 Sep 2020 21:50:38 +1000	[thread overview]
Message-ID: <202009061150.086BocJ0028707.mail.zacglen.com@localhost> (raw)
In-Reply-To: <yw1x7dt7i1yj.fsf@mansr.com>

>fbk-qriry@zacglen.net writes:
>
>> Further to my previous "silence" patch I have discovered
>> that there is another error involving the rms calculations.
>>
>> Initially, and after a reset, the rms sample window is empty
>> yet the rms calculation always uses the window size as
>> the calculation denominator. This will make the rms
>> value appear artificially low to start with. Instead, an
>> actual count of samples should be used.
>>
>> Incidentally, I think that the hard-coded 1/50 for selection
>> of a window size should also be parametized. Sometimes a size using
>> 1/20 (100 milliseconds when stereo) can be more appropriate than the
>> very small 40 millisecond hard-coded sample window size.
>>
>> The following is the updated patch:
>
>I'm certainly not going to take a patch with several unrelated changes
>as is, nor am I going to do the work unravelling what's what.
>
>-- 
>Mns Rullgrd
>

Perhaps that is why there are still so many blatant bugs in sox
after all of these years?

I have only started looking and I am sure I can find many
many more.

It is entirely up to you. I feed information into your brain
and if your brain is incapable or unwilling to digest any of it
then that is entirely your problem.

Please bear in mind that sox currently contains hundred of
related and unrelated lines of code. And that doesn't stop
sox from working does it? Unrelatedness has never been
an obstacle in the past has it?

Anyhow would you care to introduce yourself and explain how
it is that you have apparently become the sole arbiter of what
is good or bad for sox.

Incidentally, I can very easily patch sox entirely for my own
benefit and there is no compulsion for me to publish such
private changes on any public forum. I only do that out of
the goodness of my heart. The patches merely serve as a convenient
way of explaining the bugs in more detail. Once a person such as
your kind self has availed him- or her-self of the wisdom of my discoveries
then your good person is freely available to work very hard at finding
some good reason to cast aspersions upon my discoveries. But I would
submit that the easier path would be to take my discoveries on board
and make good use of what has cost me in time and effort, at no
cost to yourself.

:JW



_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

  reply	other threads:[~2020-09-06 11:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  4:16 silence additional patch fbk-qriry
2020-09-06 11:23 ` Måns Rullgård
2020-09-06 11:50   ` fbk-qriry [this message]
2020-09-06 12:45     ` Måns Rullgård
2020-09-06 12:50       ` fbk-qriry
2020-09-06 14:00         ` Cary Lewis
2020-09-07 11:32           ` Måns Rullgård
2020-09-06 11:58   ` fbk-qriry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202009061150.086BocJ0028707.mail.zacglen.com@localhost \
    --to=sox-devel@lists.sourceforge.net \
    --cc=mans@mansr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).