From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9CCBA1F66E for ; Thu, 27 Aug 2020 11:37:49 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kBGDx-0002O3-42; Thu, 27 Aug 2020 11:37:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBGDv-0002Nw-Qs for sox-devel@lists.sourceforge.net; Thu, 27 Aug 2020 11:37:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L+8VsB+8RrIJzGoaEN20NZl20Z51F38JdsgfdI0+9s4=; b=H0UBRNGLQ/jtHjZRnkJLP/mIiH 4Iluqsi0wZs5dcLld6hj+EyTurLUTnoDkTOwvqNRc3Xlje+o83RF2kwNosmRgNjDkZgWhbWDuf61s 2idPUsc6QRDNr8kKGsPdqCQvcqVH7AbFDpk4xlCONUy+asPZaxbjR3cWMBSBZZ/adaa4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=L+8VsB+8RrIJzGoaEN20NZl20Z51F38JdsgfdI0+9s4=; b=mzRsnfifFK4D4iNFhSFn4gFTry GXDHCUAG8iYHrngKe4I0yR/ijorQCs/sxF1TckwsLVwgIf+eNvmJ4IKwLuz1nYuIpQ7BiznLsWqLU XXmII12jNNzkPaq4LviHnC/EV50+oIdCHBbhexYOHUG1JksJPGMmqgjJC2CzQbpKbZyg=; Received: from uvt.stare.cz ([185.63.96.79] helo=mx.stare.cz) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kBGDr-002FsQ-Ox for sox-devel@lists.sourceforge.net; Thu, 27 Aug 2020 11:37:43 +0000 Received: from localhost (stare.cz [local]) by stare.cz (OpenSMTPD) with ESMTPA id e9f353d7; Thu, 27 Aug 2020 13:37:30 +0200 (CEST) Date: Thu, 27 Aug 2020 13:37:29 +0200 From: Jan Stary To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Message-ID: <20200827113729.GA70347@www.stare.cz> References: <20200822081738.GA14321@www.stare.cz> <20200822153545.GA61858@www.stare.cz> <20200823140733.GA9403@www.stare.cz> <20200823215551.GA83582@www.stare.cz> <20200824065643.GA91434@www.stare.cz> <20200827094048.GC5768@www.stare.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1kBGDr-002FsQ-Ox Subject: Re: Build system cleanup X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net On Aug 27 12:08:02, mans@mansr.com wrote: > Jan Stary writes: > > > On Aug 24 08:56:43, hans@stare.cz wrote: > >> On Aug 23 23:55:51, hans@stare.cz wrote: > >> > > > cc [...] -o .libs/sox sox.o -L./.libs -lsox -L/usr/local/lib -lpng [...] > >> > > > cc [...] -o .libs/sox sox.o -L/usr/local/lib -L./.libs -lsox -lpng [...] > >> > > > > >> > > > The first works, the second does not. > >> > > > The only difference between the two is the place > >> > > > where the extra -L/usr/local/lib gets added, > >> > > > as described in the previous emails. > >> > > >> > And it seems libtool itself is the one who breaks it. > >> > This is the failing line again: > >> > > >> > /bin/sh ../libtool --tag=CC --mode=link cc -g -O2 -fstack-protector-strong -Wall -Wmissing-prototypes -Wstrict-prototypes -avoid-version -module -L/usr/local/lib -Wl,--as-needed -o sox sox.o libsox.la -lm > >> > > >> > Notice the "-L/usr/local/lib -Wl,--as-needed". > >> > The "-L/usr/local/lib" part comes from the configure arg: > >> > > >> > ./configure CC=cc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib > >> > > >> > The "-Wl,--as-needed" comes from > >> > > >> > $ grep as-needed configure.ac > >> > AX_APPEND_LINK_FLAGS([-Wl,--as-needed]) > >> > > >> > That results in the following line in src/Makefile: > >> > > >> > LDFLAGS = -L/usr/local/lib -Wl,--as-needed > >> > > >> > and that's what is passed in the above command line. Now, libtool > >> > apparently preprocesses the line into something else; in particular, > >> > it reorders the options. The very next command is: > >> > > >> > libtool: link: cc -g -O2 -fstack-protector-strong -Wall -Wmissing-prototypes -Wstrict-prototypes -Wl,--as-needed -o .libs/sox sox.o -L/usr/local/lib -L./.libs -lsox -lpng -lltdl -lao -lgsm -lmad -lmp3lame -ltwolame -lid3tag -lz -lopusfile -lopus -lsndio -lvorbisfile -lwavpack -lcrypto -lsndfile -lFLAC -lvorbisenc -lvorbis -logg -lm -Wl,-rpath,/usr/local/lib > >> > > >> > Notice where the -L/usr/local/lib has been moved. > >> > As described previously, if it comes after -lsox > >> > instead of before it, it links just fine. > >> > >> That being said, the same problem is present in the master branch, > >> but it works in 14.4.2, where the libtool line is > >> > >> bin/sh ../libtool --silent --tag=CC --silent --mode=link cc -Wtraditional-co > >> nversion -g -O2 -fstack-protector -Wall -W -Wmissing-prototypes -Wstrict-protot > >> ypes -pedantic -avoid-version -module -L/usr/local/lib -o sox sox.o libsox.la > >> -lm > >> > >> which becomes (without 'silent') > >> > >> libtool: link: cc -Wtraditional-conversion -g -O2 -fstack-protector -Wall -W -Wmissing-prototypes -Wstrict-prototypes -pedantic -o .libs/sox sox.o -L/usr/local/lib -L./.libs -lsox -lltdl -lpng -lao -lgsm -lmad -lid3tag -lz -lmp3lame -ltwolame -lopusfile -lopus -lsndio -lvorbisfile -lwavpack -lcrypto -lsndfile -lFLAC -lvorbisenc -lvorbis -logg -lm -Wl,-rpath,/home/hans/lib -Wl,-rpath,/usr/local/lib > > > > Presumably, the problem does not occur wih a release, > > because it already comes with a ./configure script, > > so the builder does not have to run autoreconf -i, > > which is when the (broken) ./libtool gets created. > > So the 'libtool' called is the OpenBSD libtool, > > which does not have that bug. > > Unfortunately, that's not the case. The release tarball includes > whatever libtool script is on the system that generated it. Apparently, 14.4.2 does not: $ tar xzf /usr/ports/distfiles/sox-14.4.2.tar.gz $ find sox-14.4.2/ -name libtool _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel