From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 20D821F66E for ; Tue, 11 Aug 2020 14:33:59 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5VLg-0004bI-Av; Tue, 11 Aug 2020 14:33:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5VLf-0004bA-II for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 14:33:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QMw9uPpOwbBWXLnnZNmsjhPAz9kEz7RbsURBUMolI1s=; b=L8kaxClKPMl3xIWwlDZaT2sFNZ lT5jlrrZ4yrAXzqiJ0D4thyJcBdnsk6rV8zxz+Qm0lDsN9VYUfXgcNe1XL/s0BxBfufmCmGEKAyAT nQjY2+YZ6kj3+mzEKQh5q77vZJRaSxKtdS/XB6RxpGWOLRL1kcOJA1CjCVc4X059Iwkw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QMw9uPpOwbBWXLnnZNmsjhPAz9kEz7RbsURBUMolI1s=; b=iArVLBDlW6pexw6mOCVeQfSx7l +BaVzW+RoJInAeVGqELPCVbROldshFDdU3INuWiQNJLMNqk4/ZujS8bcPRE9/leJ83pKCYBP+pqfi ZMpZxSaQ5rAk3DFgqcLvLqCPYqBReQnUotyL7AoTTEzxpVNxeVh5gC5oZu6z2zZwN0kk=; Received: from uvt.stare.cz ([185.63.96.79] helo=mx.stare.cz) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5VLd-00606h-W5 for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 14:33:55 +0000 Received: from localhost (stare.cz [local]) by stare.cz (OpenSMTPD) with ESMTPA id 8b659437; Tue, 11 Aug 2020 16:33:39 +0200 (CEST) Date: Tue, 11 Aug 2020 16:33:38 +0200 From: Jan Stary To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Message-ID: <20200811143338.GB63033@www.stare.cz> References: <20200810121707.29623-1-mans@mansr.com> <20200811133407.GA88171@www.stare.cz> <20200811134150.GA70131@www.stare.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1k5VLd-00606h-W5 Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Cc: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net On Aug 11 15:14:29, mans@mansr.com wrote: > Jan Stary writes: > > >> > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, > >> > - [AC_CHECK_HEADERS(machine/soundcard.h, > >> > - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")], > >> > - using_oss=no)])]) > >> > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)]) > >> > >> Apparently, the presence of is not > >> a correct test of ossaudio being available in the system. > > > > Maybe I am confused by the Subject: > > "remove check for machine/soundcard.h and libossaudio" > > The checks for those things have been removed. It now only checks for > sys/soundcard.h since that better reflects what we actually want. Does that mean "if sys/soundcard.h was found, we are on a system where we want to use OSS"? > > It seems this diff does not remove, but change the way > > ossaudio is detected; namely, if sys/soundcard.h is present, > > we have oss (which is wrong, at least on OpenBSD); > > Did you fix that typo (a git pull will do it)? If not, it would > definitely "detect" it as present on any system. With that typo fixed, ./configure on OpenBSD thinks that OPTIONAL DEVICE DRIVERS ao (Xiph)..................no alsa (Linux)...............no coreaudio (Mac OS X).......no sndio (OpenBSD)............yes oss........................no pulseaudio.................no sunaudio...................yes waveaudio (MS-Windows).....no and the compilatiopn fails as in my previous email. But ./configure --without-sunaudio results in OPTIONAL DEVICE DRIVERS ao (Xiph)..................no alsa (Linux)...............no coreaudio (Mac OS X).......no sndio (OpenBSD)............yes oss........................no pulseaudio.................no sunaudio...................no waveaudio (MS-Windows).....no and it builds fine. > > also, even with oss detected, we no longer set -libossaudio, > > which also seems wrong (anywhere we want to use it). > > -lossaudio is _only_ for the emulation on *BSD. No library is required > on systems with real OSS drivers. We shouldn't be using the emulation, > so there is no need to link with the library either. Right; sorry for the confusion. Jan _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel