From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 47CF01F66E for ; Tue, 11 Aug 2020 13:34:32 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1k5UQ6-0001uI-Lp; Tue, 11 Aug 2020 13:34:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5UQ4-0001u9-0M for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 13:34:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8KuLElLpsswlIcy9Klb914ILzvCHXZiOZjjreiMugRI=; b=anBeoSMgz0tZZFyxWH0YVezCR1 rv5QsR/H0j+ywPVPfc1U8xKatPWjqisQEFBFw2VOIg/qjrfy2mb4hJW6x3vEf55x/LoAP9n3+gqJD tpwm8uwmxGg+AmMyY32pWElsM6SUWVQeU1rCP2zP7HNfdtKpfQWOKrKUg49LT13PLnJo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To: From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8KuLElLpsswlIcy9Klb914ILzvCHXZiOZjjreiMugRI=; b=Jjszn1XpVhbIRTdNUL9v7hv9j/ By+zREKyBWqbZxOfSQG5jraRao1Z50wPa3u2v6wypMfPD/35UKtxFk/qutMzAOjHen2c9ZCOqQjiy gixuFJVm8KEYMLUywNbOs0jcN5uXVjWbOc+vc26AnsX361GF6b7NPl4cfqTSeybVeF60=; Received: from uvt.stare.cz ([185.63.96.79] helo=mx.stare.cz) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1k5UQ0-00122o-9n for sox-devel@lists.sourceforge.net; Tue, 11 Aug 2020 13:34:23 +0000 Received: from localhost (stare.cz [local]) by stare.cz (OpenSMTPD) with ESMTPA id bd6df4cd for ; Tue, 11 Aug 2020 15:34:08 +0200 (CEST) Date: Tue, 11 Aug 2020 15:34:07 +0200 From: Jan Stary To: sox-devel@lists.sourceforge.net Message-ID: <20200811133407.GA88171@www.stare.cz> References: <20200810121707.29623-1-mans@mansr.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810121707.29623-1-mans@mansr.com> X-Headers-End: 1k5UQ0-00122o-9n Subject: Re: [PATCH] oss: remove check for machine/soundcard.h and libossaudio X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net This is OpenBSD/current. On Aug 10 13:17:07, mans@mansr.com wrote: > Near as I can tell, no system actually has a machine/soundcard.h file. OpenBSD has neither nor ; it has , as documented in http://man.openbsd.org/ossaudio > The libossaudio library on NetBSD and OpenBSD is meant to emulate a > few ioctl() commands to facilitate porting of Linux applications. Yes. > As we have proper sndio support, this is of no use for SoX. On OpenBSD, yes (I will look at NetBSD and FreeBSD in separate emails). Current SoX git builds and runs fine on OpenBSD (except the recent -Wl,--as-needed) using sndio, if ./configure'd right. The OpenBSD port of SoX 14.4.2 http://cvsweb.openbsd.org/ports/audio/sox/Makefile?rev=1.72 explicitly builds --without-oss --without-sunaudio --with-sndio In fact, these options are necessary (that is to say, the autodetection is broken); when ./configure'd without options, it detects each of sndio, ossaudio and sunaudio, and fails with sox.c: In function 'adjust_volume': sox.c:1337: error: 'audio_info_t' undeclared (first use in this function) sox.c:1337: error: (Each undeclared identifier is reported only once sox.c:1337: error: for each function it appears in.) sox.c:1337: error: expected ';' before 'audio_info' sox.c:1338: error: 'AUDIO_GETINFO' undeclared (first use in this function) sox.c:1338: error: 'audio_info' undeclared (first use in this function) sox.c:1341: warning: implicit declaration of function 'AUDIO_INITINFO' sox.c:1345: error: 'AUDIO_SETINFO' undeclared (first use in this function) (These are artifacts of sunaudio, right?) A naive 'grep -Fr audio_info_t .' reveals that SoX ships with src/bit-rot/ src/bit-rot/CoreAudio src/bit-rot/CoreAudio/CoreAudio.h src/bit-rot/mmreg.h src/bit-rot/mmsystem.h src/bit-rot/sndio.h src/bit-rot/sys src/bit-rot/sys/audioio.h src/bit-rot/windows.h What are these for? > --- > Are there any BSD users here who can comment on this? > --- > configure.ac | 5 +---- > src/oss.c | 3 --- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/configure.ac b/configure.ac > index b1440560181c..9f55b5f8a55c 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -609,10 +609,7 @@ AC_OPTIONAL_FORMAT(sndfile, SNDFILE, [using_sndfile=$tmp_using_sndfile]) > > > > -AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, > - [AC_CHECK_HEADERS(machine/soundcard.h, > - [AC_CHECK_LIB(ossaudio, _oss_ioctl, OSS_LIBS="$OSS_LIBS -lossaudio")], > - using_oss=no)])]) > +AC_OPTIONAL_FORMAT(oss, OSS, [AC_CHECK_HEADERS(sys/soundcard.h,, uing_oss=no)]) Apparently, the presence of is not a correct test of ossaudio being available in the system. 'uing_oss' is a typo I guess. (God I hate autotools.) Jan _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel