From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6130 216.105.38.0/24 X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS,T_DKIM_INVALID shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0F2C11F424 for ; Fri, 27 Apr 2018 23:55:11 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1fCDCh-0004mJ-VQ; Fri, 27 Apr 2018 23:55:03 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fCDCg-0004mB-NT for sox-devel@lists.sourceforge.net; Fri, 27 Apr 2018 23:55:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DuPbdy25YNpW/m5yjrk2c0jyQEYqqqV4UV3VuKzUjAo=; b=fgfycZYngtLtCo2gELYtBzvcl/ iCbhio4dOxmLaC1+9Me1M371yPk/lxychk+zX9dhw4SDNZNSTA8tvHnJy/698ZRsDcBffiFpyM1ZK QOw2ufh1gCVamL9zOZhGihCPKEhaxf/z1xo6b8TfCf+My5Uz1XFR1K3nMMMa6dXkdS2k=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DuPbdy25YNpW/m5yjrk2c0jyQEYqqqV4UV3VuKzUjAo=; b=dYWU21drjJbfCzGjC+3ktvb9Y3 viKx01/qrwCMY/ocvPTrHQkNUOVBxlLi+AjZqJon9wwl7H8xdkSF0tSZ5o8x6QC0YNTpZfoZtnoc4 JqtCH5N22Rp+SXuWBdUxJbqzn18etfAZYzyVwuOnZORcemIohXLhMJznspIzIdH4uaM8=; Received: from unicorn.mansr.com ([81.2.72.234]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fCDCe-0001Bk-PI for sox-devel@lists.sourceforge.net; Fri, 27 Apr 2018 23:55:02 +0000 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 6181D16402; Sat, 28 Apr 2018 00:54:51 +0100 (BST) From: Mans Rullgard To: sox-devel@lists.sourceforge.net Date: Sat, 28 Apr 2018 00:53:59 +0100 Message-Id: <20180427235359.7497-1-mans@mansr.com> X-Mailer: git-send-email 2.17.0 X-Headers-End: 1fCDCe-0001Bk-PI Subject: [PATCH] wav: disallow zero-size chunks [bug #278] X-BeenThere: sox-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sox-devel@lists.sourceforge.net MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: sox-devel-bounces@lists.sourceforge.net A zero-size chunk is a sign of a corrupt file, so stop reading if one is encountered. --- src/wav.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wav.c b/src/wav.c index 3b07e5e25fd3..f868dab4b294 100644 --- a/src/wav.c +++ b/src/wav.c @@ -469,7 +469,7 @@ static int findChunk(sox_format_t * ft, const char *Label, uint64_t *len) if ((*len) % 2) (*len)++; /* skip to next chunk */ - if (*len > 0 && lsx_seeki(ft, (off_t)(*len), SEEK_CUR) != SOX_SUCCESS) + if (!*len || lsx_seeki(ft, (off_t)(*len), SEEK_CUR) != SOX_SUCCESS) { lsx_fail_errno(ft,SOX_EHDR, "WAV chunk appears to have invalid size %ld.", *len); -- 2.17.0 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel