unofficial mirror
 help / color / mirror / code / Atom feed
From: Mans Rullgard <>
Subject: [PATCH] aiff: fix crash on empty comment chunk (CVE-2017-15642)
Date: Mon, 20 Nov 2017 11:05:35 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

This fixes a use after free and double free if an empty comment
chunk follows a non-empty one.
 src/aiff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/aiff.c b/src/aiff.c
index e34286be0a97..197ccd4e5d20 100644
--- a/src/aiff.c
+++ b/src/aiff.c
@@ -63,7 +63,6 @@ int lsx_aiffstartread(sox_format_t * ft)
   size_t ssndsize = 0;
   char *annotation;
   char *author;
-  char *comment = NULL;
   char *copyright;
   char *nametext;
@@ -271,6 +270,7 @@ int lsx_aiffstartread(sox_format_t * ft)
     else if (strncmp(buf, "COMT", (size_t)4) == 0) {
+      char *comment = NULL;
       rc = commentChunk(&comment, "Comment:", ft);
       if (rc) {
         /* Fail already called in function */

Check out the vibrant tech community on one of the world's most
engaging tech sites,!
SoX-devel mailing list

  reply	other threads:[~2017-11-20 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20  9:17 New CVE bug Jaromír Mikeš
2017-11-20 11:05 ` Mans Rullgard [this message]
2017-11-20 12:22   ` [PATCH] aiff: fix crash on empty comment chunk (CVE-2017-15642) Jaromír Mikeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).