Re: sox src/coreaudio device name truncation fix

[Eric Wong <normalperson@yhbt.net>]

gqrxzy8974@ftml.net wrote:
> I haven't tested this but it appears the code:
> 
> https://sourceforge.net/p/sox/code/ci/master/tree/src/coreaudio.c#l154
>                   char name[256];
>                   status = AudioDeviceGetProperty(devices[i],0,false,kAudioDevicePropertyDeviceName,&property_size,&name);
> 
> Needs to have
>                   property_size = sizeof(name);
> added before the  AudioDeviceGetProperty call.
> 
> Otherwise  property_size has the left over length from the previous request for the list of devices.  I'm seeing
> returned names truncated to 11 characters which is 12 including the \0 which matches the
> 3 device id's (at 4 bytes each) returned by the previous use of property_size.

Seems reasonable.  Can you test this?
(or provide at least provide a documentation reference).

If not, is there someone else here who can?

Thanks.

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381