sox-devel@lists.sourceforge.net unofficial mirror
 help / color / mirror / code / Atom feed
From: Wolfgang Stoeggl via SoX-devel <sox-devel@lists.sourceforge.net>
To: sox-devel <sox-devel@lists.sourceforge.net>
Cc: Wolfgang Stoeggl <c72578@yahoo.de>
Subject: Re: Bundled GSM library
Date: Wed, 5 Aug 2020 19:17:26 +0000 (UTC)	[thread overview]
Message-ID: <1296948245.711083.1596655046178@mail.yahoo.com> (raw)
In-Reply-To: <yw1ximdywrjw.fsf@mansr.com>


[-- Attachment #1.1: Type: text/plain, Size: 1251 bytes --]

Dear Måns ,

yes, libgsm available as package in many distributions, typically at the current version of 1.0.19:https://repology.org/project/gsm/versions
If a local copy is kept within sox, it should probably be updated ...
As a small sign of being interested in keeping the cmake build system for SoX, a patch for CMakeLists.txt is attached, which allows detection of gsm.h, when it is directly in the include folder in addition to detecting gsm/gsm.h so far.
The patch also includes a fix for detecting lame.h in addition to lame/lame.h
Best regards
Wolfgang 

    Am Dienstag, 4. August 2020, 13:59:27 MESZ hat Måns Rullgård <mans@mansr.com> Folgendes geschrieben:  
 
 SoX includes a local copy of libgsm.  There is also an option to build
against an externally provided libgsm.  Unsurprisingly, the local copy
is quite old and presumably full of bugs.

Since all major Linux distributions already package libgsm, I'd like to
simply delete our copy and make gsm support optional.  It is rather
obscure, after all.

Any objections?

-- 
Måns Rullgård


_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel  

[-- Attachment #1.2: Type: text/html, Size: 3101 bytes --]

[-- Attachment #2: cmake_gsm_lame.patch.gz --]
[-- Type: application/x-gzip, Size: 534 bytes --]

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



[-- Attachment #4: Type: text/plain, Size: 158 bytes --]

_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel

  reply	other threads:[~2020-08-05 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 11:58 Bundled GSM library Måns Rullgård
2020-08-05 19:17 ` Wolfgang Stoeggl via SoX-devel [this message]
2020-08-06  9:10   ` Måns Rullgård
2020-08-11 13:53 ` Jan Stary
2020-08-11 14:24   ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.sourceforge.net/lists/listinfo/sox-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296948245.711083.1596655046178@mail.yahoo.com \
    --to=sox-devel@lists.sourceforge.net \
    --cc=c72578@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/sox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).