From: usa@garbagecollect•jp
To: ruby-dev@ruby-lang.org
Subject: [ruby-dev:50458] [Ruby trunk Bug#13955] NKF.nkf のオプション文字列が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない
Date: Wed, 31 Jan 2018 13:39:50 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-70087.20180131133931.9925c16fea11de77@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-13955.20170930080126@ruby-lang.org
Issue #13955 has been updated by usa (Usaku NAKAMURA).
Backport changed from 2.3: REQUIRED, 2.4: DONE to 2.3: DONE, 2.4: DONE
ruby_2_3 r62140 merged revision(s) 60071.
----------------------------------------
Bug #13955: NKF.nkf のオプション文字列が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない
https://bugs.ruby-lang.org/issues/13955#change-70087
* Author: tommy (Masahiro Tomita)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.3: DONE, 2.4: DONE
----------------------------------------
SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、NKF.nkf のオプション文字列が正しく扱われません。
```
% ruby -rnkf -e 'opt="--ic=UTF-8 --oc=EUC-JISX0213 -w"[0,28]; p opt; p NKF.nkf(opt, "あ").encoding'
"--ic=UTF-8 --oc=EUC-JISX0213"
#<Encoding:UTF-8>
```
次のパッチで直ると思います。
```diff
diff --git a/ext/nkf/nkf.c b/ext/nkf/nkf.c
index 9613a925ce..df32e9cf0b 100644
--- a/ext/nkf/nkf.c
+++ b/ext/nkf/nkf.c
@@ -137,7 +137,7 @@ rb_nkf_convert(VALUE obj, VALUE opt, VALUE src)
{
VALUE tmp;
reinit();
- StringValue(opt);
+ StringValueCStr(opt);
nkf_split_options(RSTRING_PTR(opt));
if (!output_encoding) rb_raise(rb_eArgError, "no output encoding given");
```
適用後
```
% ruby -rnkf -e 'opt="--ic=UTF-8 --oc=EUC-JISX0213 -w"[0,28]; p opt; p NKF.nkf(opt, "あ").encoding'
"--ic=UTF-8 --oc=EUC-JISX0213"
#<Encoding:EUC-JIS-2004>
```
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2018-01-31 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-13955.20170930080126@ruby-lang.org>
2017-09-30 8:01 ` [ruby-dev:50269] [Ruby trunk Bug#13955] NKF.nkf のオプション文字列が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない tommy
2017-12-24 20:07 ` [ruby-dev:50387] " nagachika00
2018-01-31 13:39 ` usa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-70087.20180131133931.9925c16fea11de77@ruby-lang.org \
--to=ruby-dev@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).